OCPBUGS-56195: Fix live migration with feature migration configured explicitly #2710

pliurh · 2025-05-19T09:38:40Z

The function isMigrationChangeSafe reports error when feature migration configured explicitly. It prevent the live migration from being completed at the last step, when the clusterconfig controller remove the flags spec.migration.networkType and spec.migration.mode.

openshift-ci-robot · 2025-05-19T09:41:36Z

@pliurh: This pull request references Jira Issue OCPBUGS-56195, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-56195 to depend on a bug targeting a version in 4.17.0, 4.17.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The function isMigrationChangeSafe reports error when feature migration configured explicitly. It prevent the live migration from being completed at the last step, when the clusterconfig controller remove the flags spec.migration.networkType and spec.migration.mode.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pliurh · 2025-05-19T09:45:22Z

/jira refresh

openshift-ci-robot · 2025-05-19T09:45:27Z

@pliurh: This pull request references Jira Issue OCPBUGS-56195, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pliurh · 2025-05-19T09:46:16Z

/jira refresh

openshift-ci-robot · 2025-05-19T09:46:25Z

@pliurh: This pull request references Jira Issue OCPBUGS-56195, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.z) matches configured target version for branch (4.16.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-56426 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-56426 targets the "4.17.z" version, which is one of the valid target versions: 4.17.0, 4.17.z
bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pliurh · 2025-05-19T09:48:17Z

/cc @kyrtapz

kyrtapz · 2025-05-19T14:28:43Z

pkg/network/render.go

@@ -689,7 +689,9 @@ func isMigrationChangeSafe(prev, next *operv1.NetworkSpec, infraStatus *bootstra
 	if next.Migration != nil && next.Migration.Mode == operv1.LiveNetworkMigrationMode && infraStatus.HostedControlPlane != nil {
 		return []error{errors.Errorf("live migration is unsupported in a HyperShift environment")}
 	}
-	if prev.Migration != nil && next.Migration != nil && prev.Migration.NetworkType != next.Migration.NetworkType && next.Migration.Mode != operv1.LiveNetworkMigrationMode {
+	if prev.Migration != nil && next.Migration != nil && next.Migration.NetworkType != "" &&


This now allows changing the NetworkType anytime during the live migration.
Should we at least limit it to going from "set" to "unset"?

This patch is actually to allow it to go from "set" to "unset". This happens at the last step of the live migration. When no migration.featureMigration is configured, the migration field will be removed; therefore, it won't report an error here. However, when the user configures migration.featureMigration manually, the migration field will not be removed by the server-side apply. Instead, only the migration.networkType and migration.mode will be unset.

kyrtapz · 2025-05-19T14:29:07Z

pkg/network/render_test.go

+			errMsg:      "cannot change migration network type after migration has started",
+		},
+		{
+			name:        "changing network type during live migration should be valid",


We don't support such scenario do we?

The function isMigrationChangeSafe reports error when feature migration configured explicitly. It prevent the live migration from being completed at the last step, when the clusterconfig controller remove the flags spec.migration.networkType and spec.migration.mode. Signed-off-by: Peng Liu <[email protected]>

pliurh · 2025-05-20T13:34:05Z

/retest-required

pliurh · 2025-05-21T01:59:00Z

/retest-required

pliurh · 2025-05-21T08:50:00Z

/retest-required

kyrtapz · 2025-05-21T12:40:20Z

/lgtm
/label backport-risk-assessed

openshift-ci · 2025-05-21T12:42:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyrtapz, pliurh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [kyrtapz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pliurh · 2025-05-22T02:23:05Z

/retest-required

kyrtapz · 2025-05-22T12:02:28Z

/override ci/prow/e2e-gcp-ovn-upgrade
https://issues.redhat.com/browse/TRT-2133

openshift-ci · 2025-05-22T12:05:24Z

@kyrtapz: Overrode contexts on behalf of kyrtapz: ci/prow/e2e-gcp-ovn-upgrade

In response to this:

/override ci/prow/e2e-gcp-ovn-upgrade
https://issues.redhat.com/browse/TRT-2133

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2025-05-22T12:05:38Z

@pliurh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6	`80b7be1`	link	false	`/test e2e-vsphere-ovn-dualstack-primaryv6`
ci/prow/e2e-network-mtu-migration-ovn-ipv4	`80b7be1`	link	false	`/test e2e-network-mtu-migration-ovn-ipv4`
ci/prow/e2e-aws-hypershift-ovn-kubevirt	`80b7be1`	link	false	`/test e2e-aws-hypershift-ovn-kubevirt`
ci/prow/4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-upgrade	`80b7be1`	link	false	`/test 4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-upgrade`
ci/prow/security	`80b7be1`	link	false	`/test security`
ci/prow/e2e-gcp-ovn-upgrade	`80b7be1`	link	true	`/test e2e-gcp-ovn-upgrade`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci bot requested review from abhat and danwinship May 19, 2025 09:40

pliurh changed the title ~~Fix live migration with feature migration configured explicitly~~ OCPBUGS-56195: Fix live migration with feature migration configured explicitly May 19, 2025

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 19, 2025

openshift-ci bot requested a review from anuragthehatter May 19, 2025 09:46

openshift-ci bot requested a review from kyrtapz May 19, 2025 09:48

pliurh force-pushed the release-4.16 branch 2 times, most recently from 8c490ba to bc8333b Compare May 19, 2025 09:58

kyrtapz reviewed May 19, 2025

View reviewed changes

pliurh force-pushed the release-4.16 branch from bc8333b to 80b7be1 Compare May 20, 2025 07:23

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 21, 2025

openshift-ci bot assigned anuragthehatter, asood-rh and eurijon May 21, 2025

openshift-ci bot assigned huiran0826, jechen0648, Meina-rh, mffiedler, qiowang721, rbbratta and rlobillo May 21, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2025

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2025

OCPBUGS-56195: Fix live migration with feature migration configured explicitly #2710

Are you sure you want to change the base?

OCPBUGS-56195: Fix live migration with feature migration configured explicitly #2710

Uh oh!

Conversation

pliurh commented May 19, 2025

Uh oh!

openshift-ci-robot commented May 19, 2025

Uh oh!

pliurh commented May 19, 2025

Uh oh!

openshift-ci-robot commented May 19, 2025

Uh oh!

pliurh commented May 19, 2025

Uh oh!

openshift-ci-robot commented May 19, 2025

Uh oh!

pliurh commented May 19, 2025

Uh oh!

kyrtapz May 19, 2025

Choose a reason for hiding this comment

Uh oh!

pliurh May 20, 2025

Choose a reason for hiding this comment

Uh oh!

kyrtapz May 19, 2025

Choose a reason for hiding this comment

Uh oh!

pliurh May 20, 2025

Choose a reason for hiding this comment

Uh oh!

pliurh commented May 20, 2025

Uh oh!

pliurh commented May 21, 2025

Uh oh!

pliurh commented May 21, 2025

Uh oh!

kyrtapz commented May 21, 2025

Uh oh!

openshift-ci bot commented May 21, 2025

Uh oh!

pliurh commented May 22, 2025

Uh oh!

kyrtapz commented May 22, 2025

Uh oh!

openshift-ci bot commented May 22, 2025

Uh oh!

openshift-ci bot commented May 22, 2025

Uh oh!

Uh oh!