CORENET-6465: Remove unneeded logging config from managed ovn-kubernetes #2816

bradbehle · 2025-10-10T15:49:30Z

This logging configuration is not used and not needed. It should be removed so it does not cause confusion.

openshift-ci-robot · 2025-10-10T15:49:34Z

@bradbehle: This pull request references CORENET-6465 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

This logging configuration is not used and not needed. It should be removed so it does not cause confusion.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-10-10T15:49:54Z

Hi @bradbehle. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kyrtapz · 2025-10-13T07:30:54Z

/ok-to-test
/lgtm

This logging configuration is not used and not needed. It should be removed so it does not cause confusion

coderabbitai · 2025-11-06T18:36:54Z

Walkthrough

Removed the logging configuration block from the gateway section in the OVN-Kubernetes managed configuration file, eliminating libovsdblogfile, logfile-maxsize, logfile-maxbackups, and logfile-maxage keys.

Changes

Cohort / File(s)	Summary
OVN-Kubernetes Logging Configuration `bindata/network/ovn-kubernetes/managed/004-config.yaml`	Removed [logging] configuration block under [gateway] section; eliminated libovsdblogfile, logfile-maxsize, logfile-maxbackups, and logfile-maxage parameters.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Verify that removing these logging parameters does not impact gateway service startup or operational logging requirements
Confirm there are no downstream dependencies or monitoring systems relying on these specific log file paths or rotation settings

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 05d6f46 and ce47039.

📒 Files selected for processing (1)

bindata/network/ovn-kubernetes/managed/004-config.yaml (0 hunks)

💤 Files with no reviewable changes (1)

bindata/network/ovn-kubernetes/managed/004-config.yaml

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

bradbehle · 2025-11-12T17:47:45Z

/retest-required

bradbehle · 2025-11-13T06:37:57Z

/retest-required

rtheis

/lgtm

openshift-ci · 2025-11-13T11:09:11Z

@rtheis: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

bradbehle · 2025-11-13T15:15:38Z

/verified by @bradbehle

openshift-ci-robot · 2025-11-13T15:15:50Z

@bradbehle: Jira verification commands are restricted to collaborators for this repo.

In response to this:

/verified by @bradbehle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

kyrtapz · 2025-11-13T15:35:22Z

/lgtm
/verified by @bradbehle

openshift-ci-robot · 2025-11-13T15:35:34Z

@kyrtapz: This PR has been marked as verified by @bradbehle.

In response to this:

/lgtm
/verified by @bradbehle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-11-13T15:36:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradbehle, kyrtapz, rtheis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [kyrtapz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2025-11-13T16:01:27Z

/retest-required

Remaining retests: 0 against base HEAD d1321fa and 2 for PR HEAD ce47039 in total

bradbehle · 2025-11-15T01:01:16Z

/retest-required

rtheis · 2025-11-15T11:45:25Z

/retest-required

openshift-ci · 2025-11-15T13:52:20Z

@bradbehle: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	`ce47039`	link	false	`/test security`
ci/prow/4.21-upgrade-from-stable-4.20-e2e-azure-ovn-upgrade	`ce47039`	link	false	`/test 4.21-upgrade-from-stable-4.20-e2e-azure-ovn-upgrade`
ci/prow/4.21-upgrade-from-stable-4.20-e2e-aws-ovn-upgrade	`ce47039`	link	false	`/test 4.21-upgrade-from-stable-4.20-e2e-aws-ovn-upgrade`
ci/prow/4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-upgrade	`ce47039`	link	false	`/test 4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-upgrade`
ci/prow/okd-scos-e2e-aws-ovn	`ce47039`	link	false	`/test okd-scos-e2e-aws-ovn`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

rtheis · 2025-11-15T22:28:18Z

/retest-required

rtheis · 2025-11-16T18:09:53Z

/cherry-pick release-4.20

openshift-cherrypick-robot · 2025-11-16T18:10:33Z

@rtheis: new pull request created: #2838

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 10, 2025

openshift-ci bot requested review from arghosh93 and martinkennelly October 10, 2025 15:49

openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 10, 2025

openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 13, 2025

openshift-ci bot assigned kyrtapz Oct 13, 2025

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 13, 2025

Remove unneeded logging config from managed ovn-kubernetes

ce47039

This logging configuration is not used and not needed. It should be removed so it does not cause confusion

bradbehle force-pushed the remove-ovs-logging-config branch from cf4afbc to ce47039 Compare November 6, 2025 18:36

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2025

rtheis approved these changes Nov 13, 2025

View reviewed changes

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 13, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2025

openshift-merge-bot bot merged commit fda7a9f into openshift:master Nov 16, 2025
24 of 29 checks passed

openshift-cherrypick-robot mentioned this pull request Nov 16, 2025

[release-4.20] CORENET-6465: Remove unneeded logging config from managed ovn-kubernetes #2838

Open

CORENET-6465: Remove unneeded logging config from managed ovn-kubernetes #2816

CORENET-6465: Remove unneeded logging config from managed ovn-kubernetes #2816

Uh oh!

Conversation

bradbehle commented Oct 10, 2025

Uh oh!

openshift-ci-robot commented Oct 10, 2025

Uh oh!

openshift-ci bot commented Oct 10, 2025

Uh oh!

kyrtapz commented Oct 13, 2025

Uh oh!

coderabbitai bot commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

bradbehle commented Nov 12, 2025

Uh oh!

bradbehle commented Nov 13, 2025

Uh oh!

rtheis left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Nov 13, 2025

Uh oh!

bradbehle commented Nov 13, 2025

Uh oh!

openshift-ci-robot commented Nov 13, 2025

Uh oh!

kyrtapz commented Nov 13, 2025

Uh oh!

openshift-ci-robot commented Nov 13, 2025

Uh oh!

openshift-ci bot commented Nov 13, 2025

Uh oh!

openshift-ci-robot commented Nov 13, 2025

Uh oh!

bradbehle commented Nov 15, 2025

Uh oh!

rtheis commented Nov 15, 2025

Uh oh!

openshift-ci bot commented Nov 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rtheis commented Nov 15, 2025

Uh oh!

Uh oh!

rtheis commented Nov 16, 2025

Uh oh!

openshift-cherrypick-robot commented Nov 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

coderabbitai bot commented Nov 6, 2025 •

edited

Loading

openshift-ci bot commented Nov 15, 2025 •

edited

Loading