Skip to content

OCPBUGS-60218: PPC: ghw: filter out namespaces dir #1403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

OCPBUGS-60218: PPC: ghw: filter out namespaces dir #1403

wants to merge 2 commits into from

Conversation

shajmakh
Copy link
Contributor

@shajmakh shajmakh commented Oct 2, 2025

The previous code fails to run PPC when there is a namespace that has a
suffix nodes. ensure filtering the namespace directory to allow PPC to
work when such namespaces exist.

@openshift-ci openshift-ci bot requested review from Tal-or and ffromani October 2, 2025 14:53
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shajmakh
Once this PR has been reviewed and has the lgtm label, please assign marsik for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ffromani
ffromani reviewed Oct 2, 2025
View reviewed changes
ffromani
ffromani reviewed Oct 2, 2025
View reviewed changes
pkg/performanceprofile/profilecreator/ghwhandler.go
nodeName := node.GetName()
nodePathSuffix := path.Join(nodes)
nodepath, err := getMustGatherFullPathsWithFilter(mustGatherDirPath, nodePathSuffix, clusterScopedResources)
nodepath, err := getMustGatherFullPathsWithFilter(mustGatherDirPath, nodePathSuffix, clusterScopedResources, namespaces)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the core idea is to filter out clusterScopedResources and namespaces right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct. namespaces is affected by the user configuration so we should filter it out anyway

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense but need to review again why it causes issues (and why now)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, regarding "why now" it has always been the case but it is less common to have namespaces with "nodes" suffix. The bug has additional info.

@shajmakh shajmakh changed the title PPC: ghw: filter out namespaces dir OCPBUGS-60218: PPC: ghw: filter out namespaces dir Oct 3, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 3, 2025
@openshift-ci-robot
Copy link
Contributor

@shajmakh: This pull request references Jira Issue OCPBUGS-60218, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The previous code fails to run PPC when there is a namespace that has a
suffix nodes. ensure filtering the namespace directory to allow PPC to
work when such namespaces exist.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 3, 2025
@shajmakh
PPC: pkg: public consts to private
d73add4 
The consts are not used anywhere else so make them private.

Signed-off-by: Shereen Haj <[email protected]>
@shajmakh
PPC: ghw: filter out namespaces dir
0192a27 
The previous code fails to run PPC when there is a namespace that has a
suffix `nodes`. ensure filtering the namespace directory to allow PPC to
work when such namespaces exist.

Signed-off-by: Shereen Haj <[email protected]>
ffromani
ffromani reviewed Oct 3, 2025
View reviewed changes
Copy link
Contributor

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC PPC doesn't care about the content in namespaces at all, and if so this change should be good. I want to verify that before approving. With this assumption, codewise LGTM

@shajmakh
Copy link
Contributor Author

shajmakh commented Oct 6, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 6, 2025
@openshift-ci-robot
Copy link
Contributor

@shajmakh: This pull request references Jira Issue OCPBUGS-60218, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 6, 2025
@shajmakh
Copy link
Contributor Author

The failing lanes are not related to the PPC

@shajmakh
Copy link
Contributor Author

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 13, 2025

@shajmakh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 0192a27 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tal-or Tal-or Awaiting requested review from Tal-or

1 more reviewer

@ffromani ffromani ffromani left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shajmakh @openshift-ci-robot @ffromani