NO-JIRA: manifests: make template manifests valid YAML

[petr-muller]

CVO manifests present in the payload contain plain templating {{yada}} placeholders where final manifests expect to contain strings, and because { } has meaning in YAML, these manifests are invalid without template engine processing.

CVO manifests are applied by CVO itself, which processes them through the templating engine, which makes them valid YAML. In an attempt to address OCPBUGS-30080, I want to process the CVO manifests through oc adm release new machinery, which requires them to be valid YAML.

[openshift-ci-robot]

@petr-muller: This pull request references Jira Issue OCPBUGS-30090, which is invalid:

• expected the bug to be open, but it isn't
• expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.16.0" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Done-Errata) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

CVO manifests are applied by CVO itself, which processes them through the templating engine, which makes them valid YAML. In an attempt to address OCPBUGS-30090, I want to process the CVO manifests through oc adm release new machinery, which requires them to be valid YAML.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@petr-muller: This pull request references Jira Issue OCPBUGS-30080, which is invalid:

• expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

CVO manifests are applied by CVO itself, which processes them through the templating engine, which makes them valid YAML. In an attempt to address OCPBUGS-30090, I want to process the CVO manifests through oc adm release new machinery, which requires them to be valid YAML.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[petr-muller]

/wip

[petr-muller]

/retest

[petr-muller]

/test all

[petr-muller]

/retest

[openshift-ci-robot]

@petr-muller: This pull request explicitly references no jira issue.

In response to this:

CVO manifests are applied by CVO itself, which processes them through the templating engine, which makes them valid YAML. In an attempt to address OCPBUGS-30080, I want to process the CVO manifests through oc adm release new machinery, which requires them to be valid YAML.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[petr-muller]

I have marked this as NO-JIRA instead of linking OCPBUGS-30080, because this PR is just a prerequisite for a future fix in oc that I will pursue for 4.20

[wking]

/lgtm

[hongkailiu]

CVO manifests are applied by CVO itself, which processes them through the templating engine, which makes them valid YAML.

Do you mean "which makes them 'invalid' YAML"?

[petr-muller]

/cc @hongkailiu

[petr-muller]

Do you mean "which makes them 'invalid' YAML"?

Updated the description to hopefully use clearer language.

[hongkailiu]

/lgtm

[hongkailiu]

The unit test should be fixed by

$ UPDATE=true go test -count 1 -run TestRenderManifest ./pkg/payload/...

/lgtm cancel

[petr-muller]

I actually removed the comment from the deployment manifest by mistake, I will be only able to remove it once OCPBUGS-30080 is fixed.

[hongkailiu]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, petr-muller, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [petr-muller,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@petr-muller: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-agnostic-operator-devpreview	7918adf	link	false	/test e2e-agnostic-operator-devpreview
ci/prow/e2e-hypershift	7918adf	link	true	/test e2e-hypershift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.