Add the placeholder for the first test #1172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a minimal cluster-version-operator-tests CLI application, which has no tests. The application will result in a tests extension binary that will extend the openshift-tests binary with CVO tests that will reside in the CVO repository using the openshift-tests-extension [1] framework. Verifying that no tests are present: ```sh $ ./_output/linux/amd64/openshift-tests-extension list null ``` [1]: https://github.com/openshift-eng/openshift-tests-extension
Build a statically compiled openshift-tests extension binary.
Static compilation is done because [1]:
> Extension binaries are extracted from container images into a
> running Pod executing openshift-tests. Contributors do not
> necessarily know which version of RHEL the openshift-tests
> binary will be running on, so, for maximum portability,
> test extension binaries should be statically compiled.
The `GO_COMPLIANCE_POLICY="exempt_all"` is set because [1]:
> For compliance reasons, when a binary is compiled by a golang
> builder image supplied by ART, a wrapper around the go compiler
> will force FIPS compliant compilation (e.g. dynamic linking).
> For this reason, extension binaries should include
> GO_COMPLIANCE_POLICY="exempt_all" in the environment when
> compiling an extension binary. This will inhibit the wrapper from
> modifying CGO_ENABLED or other compiler arguments required for
> static compilation.
Set `CGO_ENABLED=0` to disable the use of cgo to allow
the static compilation. Otherwise, the binary is dynamically linked.
As such the usage cgo is disabled by default in the binary.
Verifying whether such a binary is built statically:
```sh
$ ldd _output/linux/amd64/openshift-tests-extension
not a dynamic executable
```
Format of the github.com/openshift-eng/openshift-tests-extension variables
is based on the existing Makefile [2] in the openshift-tests-extension repository.
[1]: https://github.com/openshift/enhancements/blob/c2c0d43e3cd70cf79bc2b101ceb6a03c5e0114a8/enhancements/testing/openshift-tests-extension.md
[2]: https://github.com/openshift-eng/openshift-tests-extension/blob/86b9979c22fd7b5022cef0e57312eda54e6e3064/Makefile
Compress the openshift-tests extension binary. Use `--force` to overwrite the output file if already present to speed up local development. Use `--keep` to keep the original binary after compressing it so that a developer may use it. Compressing because [1]: > Statically linked binaries are prohibited in FIPS and will > cause failures if detected by product pipeline scans. To > avoid this, extension binaries should be gzipped before > being committed to container images. Such a compressed binary can be then extracted as per [1]: > After discovering a test extension binary, the origin test framework will > extract the binary from the container image which carries it and store it > in /tmp storage of the pod in which it is running. > > If the binary-path ends in .gz, the binary will be decompressed. [1]: https://github.com/openshift/enhancements/blob/c2c0d43e3cd70cf79bc2b101ceb6a03c5e0114a8/enhancements/testing/openshift-tests-extension.md
|
/wip |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hongkailiu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cc |
petr-muller
reviewed
Mar 27, 2025
| @@ -118,3 +122,5 @@ require ( | |||
| sigs.k8s.io/structured-merge-diff/v4 v4.4.2 // indirect | |||
| sigs.k8s.io/yaml v1.4.0 // indirect | |||
| ) | |||
|
|
|||
| replace github.com/onsi/ginkgo/v2 => github.com/openshift/onsi-ginkgo/v2 v2.6.1-0.20241205171354-8006f302fd12 | |||
There was a problem hiding this comment.
I would not expect this in a commit that says "update vendor"?
|
@hongkailiu: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will rebase after #1168 gets in.