Skip to content

OTA-1403: Add an always passing test case #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 25, 2025
Merged

OTA-1403: Add an always passing test case #1172

merged 2 commits into from
Apr 25, 2025

Conversation

hongkailiu
Copy link
Member

Will rebase after #1168 gets in.

@hongkailiu
Copy link
Member Author

/wip

@petr-muller
Copy link
Member

/cc

@openshift-ci openshift-ci bot requested a review from petr-muller March 27, 2025 13:36
petr-muller
petr-muller reviewed Mar 27, 2025
View reviewed changes
@hongkailiu
Copy link
Member Author

/retest-required

@hongkailiu hongkailiu force-pushed the pr1168 branch 2 times, most recently from b09111d to c9ec674 Compare March 31, 2025 18:51
@hongkailiu
Copy link
Member Author

/retest

@DavidHurta
Copy link
Contributor

/cc

@openshift-ci openshift-ci bot requested a review from DavidHurta April 2, 2025 12:38
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2025
@hongkailiu hongkailiu requested a review from petr-muller April 2, 2025 14:42
@hongkailiu
Copy link
Member Author

/test all

1 similar comment
@hongkailiu
Copy link
Member Author

/test all

@hongkailiu
Copy link
Member Author

/retest

petr-muller
petr-muller approved these changes Apr 14, 2025
View reviewed changes
Copy link
Member

@petr-muller petr-muller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Big thanks for adding the README 👍

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 14, 2025
@DavidHurta
Copy link
Contributor

/hold
I want to have a look. Unblock if I am slow.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2025
@DavidHurta
Copy link
Contributor

I'll review today.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 16, 2025
DavidHurta
DavidHurta approved these changes Apr 16, 2025
View reviewed changes
Copy link
Contributor

@DavidHurta DavidHurta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for taking the time and proactively addressing the tests extension.

I am placing a hold in case you want to address my comment.

\hold

@DavidHurta
Copy link
Contributor

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 16, 2025
@petr-muller
Copy link
Member

/retest-required

1 similar comment
@hongkailiu
Copy link
Member Author

/retest-required

@hongkailiu
Copy link
Member Author

/label no-qe

as we did #1168 (comment)

For the awareness,

/cc @JianLi-RH

@openshift-ci openshift-ci bot requested a review from JianLi-RH April 17, 2025 20:25
@openshift-ci openshift-ci bot added the no-qe Allows PRs to merge without qe-approved label label Apr 17, 2025
@hongkailiu
Copy link
Member Author

/retest-required

3 similar comments
@hongkailiu
Copy link
Member Author

/retest-required

@hongkailiu
Copy link
Member Author

/retest-required

@hongkailiu
Copy link
Member Author

/retest-required

@petr-muller
Copy link
Member

/retitle NO-JIRA: Add an always passing test case

Or should this be linked to one of the actual cards?
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2025
@openshift-ci openshift-ci bot changed the title Add an always passing test case NO-JIRA: Add an always passing test case Apr 24, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 24, 2025
@openshift-ci-robot
Copy link
Contributor

@hongkailiu: This pull request explicitly references no jira issue.

In response to this:

Will rebase after #1168 gets in.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@hongkailiu hongkailiu changed the title NO-JIRA: Add an always passing test case OTA-1403: Add an always passing test case Apr 24, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 24, 2025 •
edited by openshift-ci bot
Loading

@hongkailiu: This pull request references OTA-1403 which is a valid jira issue.

In response to this:

Will rebase after #1168 gets in.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@hongkailiu
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 24, 2025 •
edited by openshift-ci bot
Loading

@hongkailiu: This pull request references OTA-1403 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@hongkailiu
Copy link
Member Author

hongkailiu commented Apr 24, 2025 •
edited by openshift-ci bot
Loading

Or should this be linked to one of the actual cards?

Linked to OTA-1403 (same as #1168)

@hongkailiu
Copy link
Member Author

/retest-required

@hongkailiu
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2025
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d949cfe and 2 for PR HEAD 1302999 in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d949cfe and 2 for PR HEAD 1302999 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 24, 2025 •
edited
Loading

@hongkailiu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-usc-devpreview f6ebe71 link false /test e2e-agnostic-usc-devpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hongkailiu
Copy link
Member Author

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit 09edded into openshift:main Apr 25, 2025
13 of 15 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cluster-version-operator
This PR has been included in build cluster-version-operator-container-v4.20.0-202504250541.p0.g09edded.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petr-muller petr-muller petr-muller approved these changes

@DavidHurta DavidHurta DavidHurta approved these changes

@JianLi-RH JianLi-RH Awaiting requested review from JianLi-RH

Assignees

@petr-muller petr-muller

@DavidHurta DavidHurta

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. no-qe Allows PRs to merge without qe-approved label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hongkailiu @petr-muller @DavidHurta @openshift-ci-robot @openshift-bot @openshift-merge-robot