Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Fix some issues identified by yamllint #1174

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hongkailiu
Copy link
Member

@hongkailiu hongkailiu commented Mar 27, 2025

See the rehearsal for the details.

The remained two will be fixed by https://github.com/openshift/cluster-version-operator/pull/1171/files#diff-d545314649981da131e9fa5eec88fd1fc37172eb51389689aa227464191bb133R72

$ yamllint --strict -d '{extends: default, rules: {indentation: {spaces: 2, indent-sequences: whatever}, document-start: disable, line-length: disable}}' ./install
./install/0000_00_cluster-version-operator_03_deployment.yaml
  73:22     error    too many spaces inside braces  (braces)
  73:38     error    too many spaces inside braces  (braces)

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 27, 2025
@openshift-ci-robot
Copy link
Contributor

@hongkailiu: This pull request explicitly references no jira issue.

In response to this:

The remained two will be fixed by https://github.com/openshift/cluster-version-operator/pull/1171/files#diff-d545314649981da131e9fa5eec88fd1fc37172eb51389689aa227464191bb133R72

$ yamllint --strict -d '{extends: default, rules: {indentation: {spaces: 2, indent-sequences: whatever}, document-start: disable, line-length: disable}}' ./install
./install/0000_00_cluster-version-operator_03_deployment.yaml
 73:22     error    too many spaces inside braces  (braces)
 73:38     error    too many spaces inside braces  (braces)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Mar 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hongkailiu
Once this PR has been reviewed and has the lgtm label, please assign pratikmahajan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hongkailiu
Copy link
Member Author

/retest-required

Copy link
Contributor

openshift-ci bot commented Mar 28, 2025

@hongkailiu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 3c7f693 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants