Skip to content

CONSOLE-4529: POC PodList using DataView PF extension #14897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Hyperkid123
Copy link

Jira: https://issues.redhat.com/browse/CONSOLE-4529

Replacing virtualized table with DataView component from PR extension.

Out of scope

Data view also provides a toolbar, however, toolbar implementation is not used here yet. It should be a follow-up once some design differences are addressed and potential issues with state management using mutable data structures.

Changes

Implement the pod PodList table using the DataView table component. Some code is copied and pasted from the virtualized table to prevent cyclic import and regressions to existing code.

The component re-uses almost all existing code. Most of the work is related to mapping current data to the required DataView format.

The infinite scroll table is replaced with a paginated table.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 24, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 24, 2025

@Hyperkid123: This pull request references CONSOLE-4529 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.19.0" version, but no target version was set.

In response to this:

Jira: https://issues.redhat.com/browse/CONSOLE-4529

Replacing virtualized table with DataView component from PR extension.

Out of scope

Data view also provides a toolbar, however, toolbar implementation is not used here yet. It should be a follow-up once some design differences are addressed and potential issues with state management using mutable data structures.

Changes

Implement the pod PodList table using the DataView table component. Some code is copied and pasted from the virtualized table to prevent cyclic import and regressions to existing code.

The component re-uses almost all existing code. Most of the work is related to mapping current data to the required DataView format.

The infinite scroll table is replaced with a paginated table.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from cajieh and Mylanos March 24, 2025 12:26
@openshift-ci openshift-ci bot added component/core Related to console core functionality needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 24, 2025
Copy link
Contributor

openshift-ci bot commented Mar 24, 2025

Hi @Hyperkid123. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Hyperkid123 Hyperkid123 changed the title CONSOLE-4529: PodList using DataView PF extension CONSOLE-4529: POC PodList using DataView PF extension Mar 24, 2025
Copy link
Contributor

openshift-ci bot commented Mar 30, 2025

@Mylanos: The label(s) /label ok-to-test cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, ux-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, plugin-api-approved, plugin-api-changed, stability-fix-approved, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 30, 2025
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Mylanos
Copy link
Contributor

Mylanos commented Mar 30, 2025

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 30, 2025
Copy link
Contributor

openshift-ci bot commented Apr 1, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Hyperkid123
Once this PR has been reviewed and has the lgtm label, please assign rawagner for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Apr 1, 2025

@Hyperkid123: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/frontend 6a816c1 link true /test frontend
ci/prow/okd-scos-e2e-aws-ovn 6a816c1 link false /test okd-scos-e2e-aws-ovn
ci/prow/images 6a816c1 link true /test images
ci/prow/e2e-gcp-console 6a816c1 link true /test e2e-gcp-console
ci/prow/okd-scos-images 6a816c1 link true /test okd-scos-images
ci/prow/backend 6a816c1 link true /test backend
ci/prow/analyze 6a816c1 link true /test analyze

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/core Related to console core functionality jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants