-
Notifications
You must be signed in to change notification settings - Fork 637
OCPBUGS-54247: Debug pod logs outputs the shell prompt duplicitly at the top of the logs. #14919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
OCPBUGS-54247: Debug pod logs outputs the shell prompt duplicitly at the top of the logs. #14919
Conversation
The first log line is being sent twice, the first time the ws socket sends only the shell prompt, second time it additionally sends the command or newline. Ignoring the first message fixed the issue with duplicit shell prompts on the first line.
@Mylanos: This pull request references Jira Issue OCPBUGS-54247, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Mylanos The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/jira refresh |
@Mylanos: This pull request references Jira Issue OCPBUGS-54247, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/hold |
@Mylanos: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The first log line is being sent twice, the first time the ws socket sends only the shell prompt, second time it additionally sends the command or newline. Ignoring the first message fixed the issue with duplicate shell prompts on the first line.
before:

after:
