Skip to content

OCPBUGS-52870: Links into OpenShift Console plugin ACM sometimes redirect user to the OpenShift dashboard. #14938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OCPBUGS-52870: Links into OpenShift Console plugin ACM sometimes redirect user to the OpenShift dashboard. #14938

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 13 additions & 15 deletions frontend/public/components/app-contents.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ const AppContents: React.FC<{}> = () => {
const location = useLocation();
const [pluginPageRoutes, inactivePluginPageRoutes] = usePluginRoutes();

const contentRouter = (
const contentRouter = allPluginsProcessed ? (
<Routes>
{pluginPageRoutes}

Expand Down Expand Up @@ -795,21 +795,19 @@ const AppContents: React.FC<{}> = () => {
{inactivePluginPageRoutes}
<Route path="/" element={<DefaultPage />} />

{allPluginsProcessed ? (
<Route
path="*"
element={
<AsyncComponent
loader={() =>
import('./error' /* webpackChunkName: "error" */).then((m) => m.ErrorPage404)
}
/>
}
/>
) : (
<Route element={<LoadingBox />} />
)}
<Route
path="*"
element={
<AsyncComponent
loader={() =>
import('./error' /* webpackChunkName: "error" */).then((m) => m.ErrorPage404)
}
/>
}
/>
</Routes>
) : (
<LoadingBox />
);

const matches = matchRoutes(namespacedRoutes, location);
Expand Down