Skip to content

ODC-6775: Jest upgrade POC #14939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

ODC-6775: Jest upgrade POC #14939

wants to merge 8 commits into from

Conversation

logonoff
Copy link
Member

@logonoff logonoff commented Apr 4, 2025

/hold

spike to find out how hard it would be to upgrade jest

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 4, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 4, 2025 •
edited by openshift-ci bot
Loading

@logonoff: This pull request references ODC-6775 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

/hold

spike to find out how hard it would be to upgrade jest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 4, 2025
@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Apr 4, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added component/dashboard Related to dashboard approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console component/gitops Related to gitops-plugin component/helm Related to helm-plugin component/knative Related to knative-plugin component/monitoring Related to monitoring component/olm Related to OLM component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared component/topology Related to topology labels Apr 4, 2025
@logonoff logonoff force-pushed the ODC-6775-jest branch 3 times, most recently from 56636be to 19e6962 Compare April 4, 2025 20:35
@logonoff logonoff force-pushed the ODC-6775-jest branch 2 times, most recently from 57409cc to d684cb0 Compare May 13, 2025 20:11
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 14, 2025
logonoff added 3 commits May 14, 2025 16:37
@logonoff
ODC-6675: Update jest
3df4e3d
@logonoff
ODC-6675: [HACK] Downgrade @types/jest
d9b7d4a 
The newer versions of `@types/jest` check the shape of mocked functions and objects with their actual counterparts.

A large number of our tests unfortunately have mocks that don't have all the properties of their real counterparts, causing many type errors.

To reduce the risk from large code changes in this PR (especially since we are so late into the 4.19 development cycle), I am going to downgrade `@types/jest` until there is time to reconcile these type errors.
@logonoff
ODC-6675: Jest runs now
7b32ab5 
- Switched from `ts-jest` to `esbuild-jest-transform` because `ts-jest` is slow
- Updated `i18next-parser` and `esbuild-loader` to latest to avoid duplicate esbuild installations in yarn.lock
- Removed `jest-resolver.js` because it was causing issues with resolving files
- Jest config moved to `jest.config.ts` because a) it is recommended and b) so we can load `tsconfig` into the esbuild jest transformer
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 14, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 20, 2025
@logonoff logonoff force-pushed the ODC-6775-jest branch 2 times, most recently from 1b2786a to c22b530 Compare May 20, 2025 20:17
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 20, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 20, 2025

@logonoff: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/frontend 5537ddc link true /test frontend
ci/prow/e2e-gcp-console 5537ddc link true /test e2e-gcp-console
ci/prow/okd-scos-e2e-aws-ovn 5537ddc link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christoph-jerolimov christoph-jerolimov Awaiting requested review from christoph-jerolimov

@jgbernalp jgbernalp Awaiting requested review from jgbernalp

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/gitops Related to gitops-plugin component/helm Related to helm-plugin component/knative Related to knative-plugin component/monitoring Related to monitoring component/olm Related to OLM component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared component/topology Related to topology do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@logonoff @openshift-ci-robot @openshift-merge-robot