-
Notifications
You must be signed in to change notification settings - Fork 640
[release-4.18] OCPBUGS-54337: Debug pod logs are not accessible when debugging a node via OpenShift Console #14942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-4.18
Are you sure you want to change the base?
Conversation
…f the debug pod. kubectl/oc exec runs a command inside a new separate terminal outside of the main terminal process within the container. In contrast, attach connects directly to the standard output and error streams of an already running main process. This is crucial towards the fix of the logs not showing the executed commands within the debug pod, because both UI and CLI logs are retrieving history from the main terminal process. Attaching the debug terminal to the main process allows for continuous log updates and ensures that the logs reflect the active state.
…l caused terminals unresponsiveness Added a logic for passing a prop that specifies if the websocket will attach or exec to the given pod. Renamed the component to reflect the functional duality of the component.
@Mylanos: This pull request references Jira Issue OCPBUGS-54337, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
1 similar comment
/retest |
@Mylanos: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/label backport-risk-assessed |
@Mylanos: Can not set label backport-risk-assessed: Must be member in one of these teams: [] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/jira refresh |
@Mylanos: This pull request references Jira Issue OCPBUGS-54337, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/label backport-risk-assessed
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhadvig, Mylanos The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
manual cherry pick of #14898 & its followup #14927.