NO-JIRA: update readme of OpenShift (with authentication) part #14975
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@vikram-raj: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
docs review: /assign @opayne1 /label px-approved |
openshift-ci
bot
added
px-approved
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: logonoff, vikram-raj The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@vikram-raj: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| @@ -86,27 +86,38 @@ oc apply -f examples/secret.yaml | |||
| oc extract secret/off-cluster-token -n openshift-console --to ./examples --confirm | |||
| ``` | |||
|
|
|||
| If you have ran `source ./contrib/oc-environment.sh` before, unset all environment variables by running the following command: | |||
There was a problem hiding this comment.
so I would probably suggest to unset these at the begining of the oc-environment.sh
|
Let me know if I need to take a look again after Jakub's comment is addressed. Updates look good to me. /label docs-approved |
openshift-ci
bot
added
the
docs-approved
/cc @jhadvig