Skip to content

WTO-324: Fix for WTO regular user tests #15048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

olkornii
Copy link

@olkornii olkornii commented May 13, 2025

Changed to draft for now. Figuring out few more problems.

@olkornii olkornii marked this pull request as draft May 13, 2025 10:23
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2025
Copy link
Contributor

openshift-ci bot commented May 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: olkornii
Once this PR has been reviewed and has the lgtm label, please assign sanketpathak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 13, 2025
Copy link
Contributor

openshift-ci bot commented May 13, 2025

Hi @olkornii. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@olkornii olkornii marked this pull request as ready for review May 15, 2025 14:28
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 15, 2025
@openshift-ci openshift-ci bot requested a review from musienko-maxim May 15, 2025 14:29
@sanketpathak
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 15, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 20, 2025
@sanketpathak
Copy link
Contributor

PR needs rebase

olkornii added 6 commits May 20, 2025 14:39
Signed-off-by: Oleksii Korniienko <[email protected]>
Signed-off-by: Oleksii Korniienko <[email protected]>
…user requires additional steps

Signed-off-by: Oleksii Korniienko <[email protected]>
Signed-off-by: Oleksii Korniienko <[email protected]>
@olkornii olkornii force-pushed the WTO-regular-user-tests branch from 3a1a9ae to 9d12d81 Compare May 20, 2025 12:45
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 20, 2025
@olkornii
Copy link
Author

@sanketpathak Rebased and force pushed.

@olkornii olkornii changed the title Fix for WTO regular user tests WTO-324: Fix for WTO regular user tests May 21, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 21, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 21, 2025

@olkornii: This pull request references WTO-324 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

Changed to draft for now. Figuring out few more problems.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented May 21, 2025

@olkornii: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console 235a9d5 link true /test e2e-gcp-console
ci/prow/frontend 235a9d5 link true /test frontend

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants