Skip to content

OCPBUGS-56264: Align ROSA logo with managed-cluster-config #15059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

logonoff
Copy link
Member

before:

Screenshot From 2025-05-15 12-51-58
Screenshot From 2025-05-15 12-52-10

after:

image
image

code review:
/assign @rhamilto

/backport release-4.19

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 15, 2025
@openshift-ci-robot
Copy link
Contributor

@logonoff: This pull request references Jira Issue OCPBUGS-56264, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

before:

Screenshot From 2025-05-15 12-51-58
Screenshot From 2025-05-15 12-52-10

after:

image
image

code review:
/assign @rhamilto

/backport release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 15, 2025
@openshift-ci-robot
Copy link
Contributor

@logonoff: This pull request references Jira Issue OCPBUGS-56264, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 15, 2025
@openshift-ci openshift-ci bot requested a review from yapei May 15, 2025 17:22
@openshift-ci openshift-ci bot requested review from jhadvig and Mylanos May 15, 2025 17:23
@logonoff logonoff force-pushed the OCPBUGS-56264-rosa branch from 3ff9d8d to 2e3e8fe Compare May 15, 2025 17:23
@openshift-ci openshift-ci bot added the component/core Related to console core functionality label May 15, 2025
Copy link
Contributor

openshift-ci bot commented May 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2025
@rhamilto
Copy link
Member

Per brand, the logo should be the three line version. The problem is, whoever is branding ROSA is using a custom branding option and not the option within console.

@logonoff
Copy link
Member Author

Per brand, the logo should be the three line version. The problem is, whoever is branding ROSA is using a custom branding option and not the option within console.

That is set here: https://github.com/openshift/managed-cluster-config/blob/master/source/html/rosa/rosa-brand-logo.svg

I thought that the current, two-line ROSA logo used in production would be aligned with brand. However, if the three-line one is the preferred logo then we can close this PR

@logonoff
Copy link
Member Author

I opened a PR to use the console-provided logo: openshift/managed-cluster-config#2426

Copy link
Contributor

openshift-ci bot commented May 15, 2025

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@logonoff logonoff closed this May 20, 2025
@logonoff logonoff deleted the OCPBUGS-56264-rosa branch May 20, 2025 12:35
@openshift-ci-robot
Copy link
Contributor

@logonoff: This pull request references Jira Issue OCPBUGS-56264. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

before:

Screenshot From 2025-05-15 12-51-58
Screenshot From 2025-05-15 12-52-10

after:

image
image

code review:
/assign @rhamilto

/backport release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants