-
Notifications
You must be signed in to change notification settings - Fork 638
OCPBUGS-56264: Align ROSA logo with managed-cluster-config #15059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@logonoff: This pull request references Jira Issue OCPBUGS-56264, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
41da12f
to
3ff9d8d
Compare
/jira refresh |
@logonoff: This pull request references Jira Issue OCPBUGS-56264, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
3ff9d8d
to
2e3e8fe
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logonoff The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Per brand, the logo should be the three line version. The problem is, whoever is branding ROSA is using a custom branding option and not the option within console. |
That is set here: https://github.com/openshift/managed-cluster-config/blob/master/source/html/rosa/rosa-brand-logo.svg I thought that the current, two-line ROSA logo used in production would be aligned with brand. However, if the three-line one is the preferred logo then we can close this PR |
I opened a PR to use the console-provided logo: openshift/managed-cluster-config#2426 |
@logonoff: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@logonoff: This pull request references Jira Issue OCPBUGS-56264. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
before:
after:
code review:
/assign @rhamilto
/backport release-4.19