ODC-7802: Remove custom Drawer and Tabs from web-terminal

[logonoff]

https://issues.redhat.com/browse/ODC-7802

changes:

• the copy/pasted PF tabs component in @console/app has been removed
• the custom Drawer component based on react-draggable has been removed
• you can now middle click "Terminal {x}" tabs to close them (like browser tabs)
• in mobile view, the terminal now expands to full-height. this is default PatternFly behaviour and AFAIK cannot be overwritten
• the terminal now animates when opening and closing
• a tooltip was added to the web terminal toggle button in the masthead

after:

tech debt, adding labels:

/label px-approved
/label docs-approved

qe approval:
/assign @sanketpathak @yapei

code review:
/assign @vikram-raj @TheRealJon

[openshift-ci-robot]

@logonoff: This pull request references ODC-7802 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/ODC-7802

changes:

• the copy/pasted PF tabs component in @console/app has been removed
• the custom Drawer component based on react-draggable has been removed
• you can now middle click "Terminal {x}" tabs to close them (like browser tabs)
• in mobile view, the terminal now expands to full-height. this is default PatternFly behaviour and AFAIK cannot be overwritten
• the terminal now animates when opening and closing
• you can no longer resize the web terminal when it is minimized
• a tooltip was added to the web terminal toggle button in the masthead

after:

tech debt, adding labels:

/label px-approved
/label docs-approved

qe approval:
/assign @sanketpathak @yapei

code review:
/assign @vikram-raj @TheRealJon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [logonoff]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@logonoff: This pull request references ODC-7802 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/ODC-7802

changes:

• the copy/pasted PF tabs component in @console/app has been removed
• the custom Drawer component based on react-draggable has been removed
• you can now middle click "Terminal {x}" tabs to close them (like browser tabs)
• in mobile view, the terminal now expands to full-height. this is default PatternFly behaviour and AFAIK cannot be overwritten
• the terminal now animates when opening and closing
• you can no longer resize the web terminal when it is minimized
• a tooltip was added to the web terminal toggle button in the masthead

after:

tech debt, adding labels:

/label px-approved
/label docs-approved

qe approval:
/assign @sanketpathak @yapei

code review:
/assign @vikram-raj @TheRealJon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[logonoff]

/retest

[yapei]

Tested the PR and found two possible regressions

• Minimize terminal will close all opened Terminals which I think should be unexpected, recording
• command line terminal occupies the whole screen on mobile view, and there is no Minimize terminal button and not able to close the terminal recording

[logonoff]

hi @yapei,

thanks for checking the PR! the first issue is definitely a regression, which should be fixed now. I also made further changes so that you can resize the web terminal even if it's minimized (like how it was before)

the second issue regarding the web terminal taking up the whole screen is unfortunately a design choice by PatternFly--in their drawer component any drawer will automatically take up the entire mobile viewport. because of this, you cannot minimize or resize drawers in mobile, so i intentionally removed the button because it would not work. we can consult with UX to see if disabling the button instead is better if you would like

code review:
/assign @rhamilto

[openshift-ci-robot]

@logonoff: This pull request references ODC-7802 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/ODC-7802

changes:

• the copy/pasted PF tabs component in @console/app has been removed
• the custom Drawer component based on react-draggable has been removed
• you can now middle click "Terminal {x}" tabs to close them (like browser tabs)
• in mobile view, the terminal now expands to full-height. this is default PatternFly behaviour and AFAIK cannot be overwritten
• the terminal now animates when opening and closing
• a tooltip was added to the web terminal toggle button in the masthead

after:

tech debt, adding labels:

/label px-approved
/label docs-approved

qe approval:
/assign @sanketpathak @yapei

code review:
/assign @vikram-raj @TheRealJon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@logonoff: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-console	7dddebc	link	unknown	/test e2e-gcp-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[yapei]

@logonoff

the second issue regarding the web terminal taking up the whole screen is unfortunately a design choice by PatternFly--in their drawer component any drawer will automatically take up the entire mobile viewport. because of this, you cannot minimize or resize drawers in mobile, so i intentionally removed the button because it would not work
sounds reasonable! thanks for confirmation

tested with the latest changes and now everything works well as expected
/label qe-approved

[openshift-ci-robot]

@logonoff: This pull request references ODC-7802 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/ODC-7802

changes:

• the copy/pasted PF tabs component in @console/app has been removed
• the custom Drawer component based on react-draggable has been removed
• you can now middle click "Terminal {x}" tabs to close them (like browser tabs)
• in mobile view, the terminal now expands to full-height. this is default PatternFly behaviour and AFAIK cannot be overwritten
• the terminal now animates when opening and closing
• a tooltip was added to the web terminal toggle button in the masthead

after:

tech debt, adding labels:

/label px-approved
/label docs-approved

qe approval:
/assign @sanketpathak @yapei

code review:
/assign @vikram-raj @TheRealJon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.