Skip to content

CONSOLE-4580: Refactor PVCActionFactory to hook form. #15078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 28, 2025
Merged

CONSOLE-4580: Refactor PVCActionFactory to hook form. #15078

merged 7 commits into from
Jun 28, 2025

Conversation

Mylanos
Copy link
Contributor

@Mylanos Mylanos commented May 22, 2025 •
edited
Loading

Moved away from using the generic kebabFactory for PVC actions that were used inside of the PVC and VolumeSnapshot page. Created hook providers that are being used in these two resource pages to access PVC actions instead. Converted persistent-volume-claim.jsx to TS.
before:

Screen.Recording.2025-05-29.at.14.49.46.mov

after(no change):

Screen.Recording.2025-05-22.at.11.38.55.mov

Possible tests:

  1. Do all of the actions in PVCs and VolumeSnapshot list and details page behave as expected?
  2. Does the PVC and VolumeSnapshot list and details page contain all of the expected actions?

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 22, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 22, 2025 •
edited by openshift-ci bot
Loading

@Mylanos: This pull request references CONSOLE-4580 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Moved away from using the generic kebabFactory for PVC actions that were used inside of the PVC and VolumeSnapshot page. Created hook providers for these two resources that are being used to access PVC actions instead. Converted persistent-volume-claim.jsx to ts.
after:

Screen.Recording.2025-05-22.at.11.38.55.mov

Possible tests:

  1. Do all of the actions in PVCs and VolumeSnapshot behave as expected?
  2. Does the PVC and VolumeSnapshot page contain all of the expected actions?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 22, 2025
@openshift-ci openshift-ci bot requested review from cajieh and rhamilto May 22, 2025 09:45
@openshift-ci openshift-ci bot added component/core Related to console core functionality kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 22, 2025
@Mylanos Mylanos force-pushed the PVCActionFactory-refactor branch from 3910a30 to 2c04374 Compare May 22, 2025 09:49
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 22, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 22, 2025 •
edited by openshift-ci bot
Loading

@Mylanos: This pull request references CONSOLE-4580 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Moved away from using the generic kebabFactory for PVC actions that were used inside of the PVC and VolumeSnapshot page. Created hook providers that are being used in these two resource pages to access PVC actions instead. Converted persistent-volume-claim.jsx to TS.
after:

Screen.Recording.2025-05-22.at.11.38.55.mov

Possible tests:

  1. Do all of the actions in PVCs and VolumeSnapshot behave as expected?
  2. Does the PVC and VolumeSnapshot page contain all of the expected actions?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 22, 2025 •
edited by openshift-ci bot
Loading

@Mylanos: This pull request references CONSOLE-4580 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Moved away from using the generic kebabFactory for PVC actions that were used inside of the PVC and VolumeSnapshot page. Created hook providers that are being used in these two resource pages to access PVC actions instead. Converted persistent-volume-claim.jsx to TS.
after:

Screen.Recording.2025-05-22.at.11.38.55.mov

Possible tests:

  1. Do all of the actions in PVCs and VolumeSnapshot list and details page behave as expected?
  2. Does the PVC and VolumeSnapshot list and details page contain all of the expected actions?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 22, 2025 •
edited by openshift-ci bot
Loading

@Mylanos: This pull request references CONSOLE-4580 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Moved away from using the generic kebabFactory for PVC actions that were used inside of the PVC and VolumeSnapshot page. Created hook providers that are being used in these two resource pages to access PVC actions instead. Converted persistent-volume-claim.jsx to TS.
after:

Screen.Recording.2025-05-22.at.11.38.55.mov

Possible tests:

  1. Do all of the actions in PVCs and VolumeSnapshot list and details page behave as expected?
  2. Does the PVC and VolumeSnapshot list and details page contain all of the expected actions?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Mylanos Mylanos force-pushed the PVCActionFactory-refactor branch from 2c04374 to 40e05c5 Compare May 22, 2025 11:06
@Mylanos
Copy link
Contributor Author

Mylanos commented May 26, 2025

/retest

Mylanos
Mylanos commented May 27, 2025
View reviewed changes
Mylanos
Mylanos commented May 27, 2025
View reviewed changes
Mylanos
Mylanos commented May 27, 2025
View reviewed changes
Mylanos
Mylanos commented May 27, 2025
View reviewed changes
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 28, 2025
@Mylanos
Copy link
Contributor Author

Mylanos commented May 28, 2025

Review comments above are made on behalf of @vojtechszocs, @jon.

@Mylanos Mylanos force-pushed the PVCActionFactory-refactor branch from eb4bdab to afe8cbb Compare May 29, 2025 12:33
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 29, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 29, 2025 •
edited by openshift-ci bot
Loading

@Mylanos: This pull request references CONSOLE-4580 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Moved away from using the generic kebabFactory for PVC actions that were used inside of the PVC and VolumeSnapshot page. Created hook providers that are being used in these two resource pages to access PVC actions instead. Converted persistent-volume-claim.jsx to TS.
before:

Screen.Recording.2025-05-29.at.14.49.46.mov

after:

Screen.Recording.2025-05-22.at.11.38.55.mov

Possible tests:

  1. Do all of the actions in PVCs and VolumeSnapshot list and details page behave as expected?
  2. Does the PVC and VolumeSnapshot list and details page contain all of the expected actions?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Mylanos Mylanos force-pushed the PVCActionFactory-refactor branch from afe8cbb to 3a5e98f Compare May 29, 2025 13:22
@Mylanos
Copy link
Contributor Author

Mylanos commented May 30, 2025

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 3, 2025
@Mylanos Mylanos force-pushed the PVCActionFactory-refactor branch 2 times, most recently from b6ec895 to 238f118 Compare June 5, 2025 13:21
@yanpzhan
Copy link
Contributor

Checked on cluster launched against the pr. There is not reaction when click 'Restore as a PVC' in volumesnapshot action list.

@Mylanos
CONSOLE-4580: address review comments, deep compare passed filterActi…
46d6886 
…ons argument in action hooks to provide stability across renders.
@Mylanos Mylanos force-pushed the PVCActionFactory-refactor branch from 2386b4c to 46d6886 Compare June 24, 2025 13:59
@Mylanos
Copy link
Contributor Author

Mylanos commented Jun 24, 2025

Updated! I have't used the right prop name for the restorePVCModal. @yanpzhan

@Mylanos
Copy link
Contributor Author

Mylanos commented Jun 24, 2025

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 24, 2025
@Mylanos
Copy link
Contributor Author

Mylanos commented Jun 24, 2025

/retest

1 similar comment
@Mylanos
Copy link
Contributor Author

Mylanos commented Jun 25, 2025

/retest

@yanpzhan
Copy link
Contributor

Retested against the pr, now all items in PVC/VolumeSnapshot action/kebab list worked well.
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jun 25, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 25, 2025 •
edited by openshift-ci bot
Loading

@Mylanos: This pull request references CONSOLE-4580 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Moved away from using the generic kebabFactory for PVC actions that were used inside of the PVC and VolumeSnapshot page. Created hook providers that are being used in these two resource pages to access PVC actions instead. Converted persistent-volume-claim.jsx to TS.
before:

Screen.Recording.2025-05-29.at.14.49.46.mov

after(no change):

Screen.Recording.2025-05-22.at.11.38.55.mov

Possible tests:

  1. Do all of the actions in PVCs and VolumeSnapshot list and details page behave as expected?
  2. Does the PVC and VolumeSnapshot list and details page contain all of the expected actions?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Mylanos
Copy link
Contributor Author

Mylanos commented Jun 25, 2025

/retest

1 similar comment
@Mylanos
Copy link
Contributor Author

Mylanos commented Jun 26, 2025

/retest

@vojtechszocs
Copy link
Contributor

/lgtm

@Mylanos
Copy link
Contributor Author

Mylanos commented Jun 27, 2025

tech debt
/label docs-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. labels Jun 27, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Mylanos, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Mylanos
Copy link
Contributor Author

Mylanos commented Jun 27, 2025

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Jun 27, 2025
@Mylanos
Copy link
Contributor Author

Mylanos commented Jun 27, 2025

/retest

1 similar comment
@Mylanos
Copy link
Contributor Author

Mylanos commented Jun 27, 2025

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 12063a1 and 2 for PR HEAD 46d6886 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 96cfa43 and 1 for PR HEAD 46d6886 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD fa89ace and 0 for PR HEAD 46d6886 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 28, 2025

@Mylanos: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5862c7b into openshift:main Jun 28, 2025
7 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console
This PR has been included in build openshift-enterprise-console-container-v4.20.0-202506281442.p0.g5862c7b.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vojtechszocs vojtechszocs vojtechszocs left review comments

@cajieh cajieh Awaiting requested review from cajieh

@rhamilto rhamilto Awaiting requested review from rhamilto

Assignees

@vojtechszocs vojtechszocs

@yanpzhan yanpzhan

@yapei yapei

@TheRealJon TheRealJon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Mylanos @openshift-ci-robot @yanpzhan @vojtechszocs @openshift-bot @yapei @TheRealJon @openshift-merge-robot