OCPBUGS-84564: remove block volume mode in case of ocs-storagecluster-ceph-nfs

[Harshvardhan-handa123]

Jira link: https://redhat.atlassian.net/browse/OCPBUGS-84564

Description: Removed the option for block volume mode when the storage class is set to ocs-storagecluster-ceph-nfs.

SS:

Summary by CodeRabbit

• New Features
  • Added support for NFS CSI (Ceph) as a storage provisioner, enabling users to provision persistent storage with both Filesystem and Block access modes.

[openshift-ci]

Hi @Harshvardhan-handa123. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[coderabbitai]

📝 Walkthrough

Walkthrough

This change extends the provisionerAccessModeMapping constant in the shared storage utilities to register the nfs.csi.ceph.com CSI provisioner. The new entry declares supported access modes for Filesystem provisioning (ReadWriteOnce, ReadWriteMany, ReadWriteOncePod) and enables partial name matching for provisioner resolution. The modification maintains the existing data structure and does not alter other storage-related logic or exported interfaces.

🚥 Pre-merge checks | ✅ 10 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is largely incomplete against the template. While a Jira link and basic description are provided, it lacks most required sections: Analysis/Root cause, Solution description details, Test setup, Test cases, Browser conformance, and Reviewers/assignees.	Complete the PR description using the template: add detailed Analysis/Root cause, expanded Solution description explaining the provisioner mapping logic, Test setup/cases, Browser conformance checklist, and appropriate reviewer/assignee tags.
Title check	⚠️ Warning	The PR title claims to 'remove block volume mode' but the actual change adds a provisioner entry with both Filesystem AND Block access modes enabled.	Revise the title to accurately reflect the change: something like 'Add nfs.csi.ceph.com provisioner configuration to provisionerAccessModeMapping' would better describe what the code actually does.

✅ Passed checks (10 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Check is not applicable. This PR contains only frontend TypeScript changes and Jest tests, not Ginkgo Go tests. The custom check targets Ginkgo test names specifically.
Test Structure And Quality	✅ Passed	Custom check for Ginkgo test quality is not applicable. PR modifies frontend TypeScript storage configuration only. No Ginkgo tests are present in this PR.
Microshift Test Compatibility	✅ Passed	No Ginkgo e2e tests are added in this PR—only a TypeScript frontend config update. The MicroShift compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR only modifies frontend storage configuration (provisioner access modes for nfs.csi.ceph.com). No new Ginkgo e2e tests added. Check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	Frontend UI configuration file only. No deployment manifests, operator code, controllers, or scheduling constraints introduced.
Ote Binary Stdout Contract	✅ Passed	PR modifies only frontend TypeScript config for storage provisioners. OTE Binary Stdout Contract applies exclusively to Go testing binaries and process-level code. No Go code changes present.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Check not applicable: PR modifies only frontend TypeScript config file (shared.ts) adding a provisioner mapping entry. No Ginkgo e2e tests are added; check targets e2e tests only.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[bipuladh]

At some point we should support an extension point for this. WDYT @spadgett ?

[bipuladh]

/ok-to-test

[logonoff]

/retitle OCPBUGS-84564: remove block volume mode in case of ocs-storagecluster-ceph-nfs
/verified by screenshot

[logonoff]

/lgtm

[openshift-ci-robot]

@Harshvardhan-handa123: This pull request references Jira Issue OCPBUGS-84564, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Jira link: https://redhat.atlassian.net/browse/OCPBUGS-84564

Description: Removed the option for block volume mode when the storage class is set to ocs-storagecluster-ceph-nfs.

SS:

Summary by CodeRabbit

• New Features
• Added support for NFS CSI (Ceph) as a storage provisioner, enabling users to provision persistent storage with both Filesystem and Block access modes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@logonoff: This PR has been marked as verified by screenshot.

Details

In response to this:

/retitle OCPBUGS-84564: remove block volume mode in case of ocs-storagecluster-ceph-nfs
/verified by screenshot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 2291108 and 2 for PR HEAD 2465f9c in total

[SanjalKatiyar]

@Rakshith-R can u plz confirm if these are supported access modes for NFS, or we need to add/remove any ??

[Rakshith-R]

NFS should be same as cephFS

NVME-Of same as RBD.

[SanjalKatiyar]

/hold
will wait for confirmation here: https://github.com/openshift/console/pull/16397/changes#r3206905036

[SanjalKatiyar]

/hold cancel

[SanjalKatiyar]

/lgtm

[SanjalKatiyar]

/cherry-pick release-4.22

[openshift-cherrypick-robot]

@SanjalKatiyar: once the present PR merges, I will cherry-pick it on top of release-4.22 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Rakshith-R]

LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harshvardhan-handa123, logonoff, Rakshith-R, SanjalKatiyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [logonoff]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bipuladh]

/label docs-approved

[fsgreco]

/verified by screenshot and CI

[openshift-ci-robot]

@fsgreco: This PR has been marked as verified by screenshot and CI.

Details

In response to this:

/verified by screenshot and CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD aa82017 and 2 for PR HEAD 3ab423c in total

[logonoff]

/test all

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 26f091b and 2 for PR HEAD 3ab423c in total

[openshift-ci]

@Harshvardhan-handa123: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@Harshvardhan-handa123: Jira Issue Verification Checks: Jira Issue OCPBUGS-84564
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-84564 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Jira link: https://redhat.atlassian.net/browse/OCPBUGS-84564

Description: Removed the option for block volume mode when the storage class is set to ocs-storagecluster-ceph-nfs.

SS:

Summary by CodeRabbit

• New Features
• Added support for NFS CSI (Ceph) as a storage provisioner, enabling users to provision persistent storage with both Filesystem and Block access modes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-cherrypick-robot]

@SanjalKatiyar: new pull request created: #16833

Details

In response to this:

/cherry-pick release-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.