[backplane-2.8] MGMT-20069: fix the hot-loop in case dataImage hang while deleting #247
Conversation
…e imageclusterinstall controller was updating the requiremntsMet status condition to diffrent values in each reconcile which caused a hot-loop This change move the requiremntsMet status update to True only after all failure cases pass Signed-off-by: Eran Cohen <[email protected]>
|
@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: MGMT-20024 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
carbonin
changed the title
|
@openshift-cherrypick-robot: This pull request references MGMT-20069 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carbonin, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
This is an automated cherry-pick of #234
/assign carbonin