Skip to content

Conversation

@opokornyy
Copy link
Contributor

This commit is enforcing min value for the dataReporting interval. The value is set to 10 minutes to avoid overloading processing API with way too many gathering jobs. The config is updated for both configmap and secret.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • None

Documentation

  • None

Unit Tests

  • pkg/config/configobserver/config_test.go
  • pkg/config/configobserver/secretconfigobserver_test.go
  • pkg/config/config_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-15589

This commit is enforcing min value for the
dataReporting interval. The value is set to 10min
to avoid overloading processing api with way too
many gathering jobs.

Signed-off-by: Ondrej Pokorny <[email protected]>
This commit is enforcing minimal value for the
interval in the support secret.

Signed-off-by: Ondrej Pokorny <[email protected]>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 4, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 4, 2025

@opokornyy: This pull request references CCXDEV-15589 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

Details

In response to this:

This commit is enforcing min value for the dataReporting interval. The value is set to 10 minutes to avoid overloading processing API with way too many gathering jobs. The config is updated for both configmap and secret.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • None

Documentation

  • None

Unit Tests

  • pkg/config/configobserver/config_test.go
  • pkg/config/configobserver/secretconfigobserver_test.go
  • pkg/config/config_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-15589

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from BaiyangZhou and ncaak November 4, 2025 09:45
@openshift-ci
Copy link

openshift-ci bot commented Nov 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: opokornyy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2025
@opokornyy
Copy link
Contributor Author

/retest

8 similar comments
@opokornyy
Copy link
Contributor Author

/retest

@BaiyangZhou
Copy link

/retest

@BaiyangZhou
Copy link

/retest

@opokornyy
Copy link
Contributor Author

/retest

@BaiyangZhou
Copy link

/retest

@BaiyangZhou
Copy link

/retest

@opokornyy
Copy link
Contributor Author

/retest

@BaiyangZhou
Copy link

/retest

Copy link
Contributor

@ncaak ncaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2025
@BaiyangZhou
Copy link

/retest

2 similar comments
@BaiyangZhou
Copy link

/retest

@BaiyangZhou
Copy link

/retest

@BaiyangZhou
Copy link

/test insights-operator-e2e-tests

@BaiyangZhou
Copy link

/test e2e-gcp-ovn-techpreview

@BaiyangZhou
Copy link

/retest

2 similar comments
@BaiyangZhou
Copy link

/retest

@BaiyangZhou
Copy link

/retest

@BaiyangZhou
Copy link

/test insights-operator-e2e-tests

@BaiyangZhou
Copy link

/retest

@opokornyy
Copy link
Contributor Author

/retest

@BaiyangZhou
Copy link

/test e2e-gcp-ovn-techpreview

@BaiyangZhou
Copy link

/test insights-operator-e2e-tests

@opokornyy
Copy link
Contributor Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Nov 20, 2025

@opokornyy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-techpreview de24a31 link true /test e2e-gcp-ovn-techpreview
ci/prow/insights-operator-e2e-tests de24a31 link true /test insights-operator-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants