CCXDEV-15591: on demand gathering job limit #1186
Conversation
This commit adds an informer that watches updates to the DataGather CR and introduces functionality to limit the number of running on-demand gathering jobs. Signed-off-by: Ondrej Pokorny <[email protected]>
Signed-off-by: Ondrej Pokorny <[email protected]>
openshift-ci-robot
added
the
jira/valid-reference
|
@opokornyy: This pull request references CCXDEV-15591 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: opokornyy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test e2e-gcp-ovn-techpreview |
1 similar comment
|
/test e2e-gcp-ovn-techpreview |
| } | ||
| } | ||
|
|
||
| const gatheringLimit = 3 |
There was a problem hiding this comment.
This value was used for testing, and we should still discuss whether it should be configurable or not. If not, we need to decide what value should be used here.
opokornyy
changed the title
|
/retest |
|
/test e2e-gcp-ovn-techpreview |
3 similar comments
|
/test e2e-gcp-ovn-techpreview |
|
/test e2e-gcp-ovn-techpreview |
|
/test e2e-gcp-ovn-techpreview |
|
/retest |
|
/test e2e-gcp-ovn-techpreview |
5 similar comments
|
/test e2e-gcp-ovn-techpreview |
|
/test e2e-gcp-ovn-techpreview |
|
/test e2e-gcp-ovn-techpreview |
|
/test e2e-gcp-ovn-techpreview |
|
/test e2e-gcp-ovn-techpreview |
|
@opokornyy: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/hold This needs to be resolved first - #1186 (comment) |
openshift-ci
bot
added
the
do-not-merge/hold
3 participants
This PR adds an informer that watches updates to the DataGather CR and introduces functionality to limit the number of running on-demand gathering jobs.
Categories
Sample Archive
NoneDocumentation
NoneUnit Tests
pkg/controller/periodic/periodic_test.gopkg/controller/periodic/datagather_informer_test.goPrivacy
Yes. There are no sensitive data in the newly collected information.
Changelog
NoneBreaking Changes
No
References
CCXDEV-15591