Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsmasq.conf: remove strict-order and add dns-forward-max #263

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ventifus
Copy link
Contributor

@ventifus ventifus commented Mar 19, 2025

Which issue this PR addresses:

Fixes ARO-2799 and ARO-15424

Companion PR to Azure/ARO-RP#4135

What this PR does / why we need it:

Implementation of ADR: https://docs.google.com/document/d/1nA1udF8RbJdpFgW3sezlEQGPMgqEQAZ7zvbCu18Zr5Q/

I also slipped in a small tweak to the etchosts template since my editor kept wanting to delete the trailing space from storage_files_testdata.go

@openshift-ci openshift-ci bot requested review from bitoku and cadenmarchese March 19, 2025 23:48
Copy link
Contributor

openshift-ci bot commented Mar 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ventifus
Once this PR has been reviewed and has the lgtm label, please assign hlipsig for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Mar 19, 2025

@ventifus: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant