Skip to content

Conversation

@shubhadapaithankar
Copy link

The go.work and go.work.sum files were accidentally included when vendoring the Azure SDK azidentity package. These files cause build failures with "directory cmd/aro is contained in a module that is not one of the workspace modules listed in go.work" error.

Removing these files fixes the build.

The go.work and go.work.sum files were accidentally included when
vendoring the Azure SDK azidentity package. These files cause build
failures with "directory cmd/aro is contained in a module that is
not one of the workspace modules listed in go.work" error.

Removing these files fixes the build.
@openshift-ci openshift-ci bot requested review from hlipsig and yjst2012 January 29, 2026 16:19
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 29, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shubhadapaithankar
Once this PR has been reviewed and has the lgtm label, please assign hlipsig for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@cadenmarchese cadenmarchese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We wouldn't want to manually remove files from vendor, instead we'd want to facilitate the removal with go mod commands (probably go mod tidy). If the files are still getting brought in, we'd want to understand the dependency issue that is causing them to be vendored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants