OCPSTRAT-2713: Bump ignition from 3.2 to 3.6 by fangge1212 · Pull Request #10392 · openshift/installer

fangge1212 · 2026-03-16T07:07:48Z

The latest ignition contains the API addtion to deploy confidential clusters.

coderabbitai · 2026-03-16T07:08:16Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: acabf73c-a710-4579-a899-3eb747530366

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Walkthrough

Upgrades numerous Go module dependencies in go.mod and replaces Ignition imports from github.com/coreos/ignition/v2/config/v3_2 to v3_6 across the codebase, updating type package references (including exported struct fields that reference igntypes.Config).

Changes

Cohort / File(s)	Summary
Dependency Management `go.mod`	Bumps many modules (cloud.google.com/go, Azure SDKs, coreos ignition, google.golang.org/, golang.org/x/, go.opentelemetry.*, grpc, genproto, and numerous indirects).
Agent asset ignition `pkg/asset/agent/image/ignition.go`, `pkg/asset/agent/image/ignition_test.go`, `pkg/asset/agent/image/unconfigured_ignition.go`, `pkg/asset/agent/joiner/clusterinfo.go`, `pkg/asset/agent/joiner/clusterinfo_test.go`	Imports switched from ignition v3_2 → v3_6; igntypes alias updated.
Cluster / bootstrap ignition `pkg/asset/cluster/tfvars/tfvars.go`, `pkg/asset/ignition/bootstrap/ibmcloud/storage.go`, `pkg/asset/ignition/bootstrap/bootstrap_ignition.go`, `pkg/asset/ignition/bootstrap/bootstrap_ignition_test.go`, `pkg/asset/ignition/bootstrap/common.go`	Ignition types import upgraded to v3_6; usages updated to new package path.
Machine asset ignition `pkg/asset/ignition/machine/arbiter.go`, `pkg/asset/ignition/machine/arbiter_ignition_customizations_test.go`, `pkg/asset/ignition/machine/master.go`, `pkg/asset/ignition/machine/node.go`, `pkg/asset/ignition/machine/worker.go`	Ignition types import updated to v3_6. Note: exported structs that hold igntypes.Config (e.g., Worker.Config, Master.Config) now reference the v3_6 types package.
Image-based ignition `pkg/asset/imagebased/image/ignition.go`, `pkg/asset/imagebased/image/ignition_test.go`	Switched ignition imports and parse surface from v3_2 → v3_6; tests updated accordingly.
MachineConfig ignition usages `pkg/asset/machines/machineconfig/authorizedkeys.go`, `pkg/asset/machines/machineconfig/chrony.go`, `pkg/asset/machines/machineconfig/disks.go`, `pkg/asset/machines/machineconfig/disks_test.go`, `pkg/asset/machines/machineconfig/fips.go`, `pkg/asset/machines/machineconfig/hyperthreading.go`, `pkg/asset/machines/machineconfig/ipv6.go`, `pkg/asset/machines/machineconfig/multipath.go`, `pkg/asset/machines/machineconfig/powersmt.go`, `pkg/asset/machines/machineconfig/routes.go`	All ignition types imports moved to v3_6; code continues constructing Ignition objects but references the newer types package.
Infrastructure ignition `pkg/infrastructure/baremetal/bootstrap.go`, `pkg/infrastructure/clusterapi/helpers.go`, `pkg/infrastructure/clusterapi/ignition.go`, `pkg/infrastructure/openstack/preprovision/bootstrapignition.go`	Ignition types imports updated to v3_6 across infra providers.
Bootstrap / other ignition `pkg/asset/ignition/bootstrap/bootstrap_ignition.go`, `pkg/asset/ignition/bootstrap/bootstrap_ignition_test.go`, `pkg/asset/ignition/bootstrap/common.go`, `pkg/asset/ignition/node.go`	Ignition types import changed to v3_6; usages updated.
Other types/helpers `pkg/types/nutanix/helpers.go`	Ignition types import changed to v3_6 in Nutanix helper.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

📝 Coding Plan

Generate coding plan for human review comments

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci · 2026-03-16T07:09:05Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bfournie for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2026-03-16T11:24:27Z

@fangge1212: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi-ovn-swapped-hosts	`b7c3925`	link	false	`/test e2e-metal-ipi-ovn-swapped-hosts`
ci/prow/e2e-openstack-nfv-intel	`b7c3925`	link	false	`/test e2e-openstack-nfv-intel`
ci/prow/e2e-agent-sno-ipv4-pxe	`b7c3925`	link	false	`/test e2e-agent-sno-ipv4-pxe`
ci/prow/e2e-ibmcloud-ovn	`b7c3925`	link	false	`/test e2e-ibmcloud-ovn`
ci/prow/e2e-gcp-ovn	`b7c3925`	link	true	`/test e2e-gcp-ovn`
ci/prow/e2e-azure-ovn-shared-vpc	`b7c3925`	link	false	`/test e2e-azure-ovn-shared-vpc`
ci/prow/azure-private	`b7c3925`	link	false	`/test azure-private`
ci/prow/e2e-agent-sno-ipv6	`b7c3925`	link	false	`/test e2e-agent-sno-ipv6`
ci/prow/e2e-gcp-secureboot	`b7c3925`	link	false	`/test e2e-gcp-secureboot`
ci/prow/e2e-gcp-ovn-xpn	`b7c3925`	link	false	`/test e2e-gcp-ovn-xpn`
ci/prow/e2e-agent-two-node-fencing-ipv4	`b7c3925`	link	false	`/test e2e-agent-two-node-fencing-ipv4`
ci/prow/e2e-metal-ipi-ovn-dualstack	`b7c3925`	link	false	`/test e2e-metal-ipi-ovn-dualstack`
ci/prow/gcp-private	`b7c3925`	link	false	`/test gcp-private`
ci/prow/e2e-gcp-ovn-byo-vpc	`b7c3925`	link	false	`/test e2e-gcp-ovn-byo-vpc`
ci/prow/e2e-agent-compact-ipv4-appliance-diskimage	`b7c3925`	link	false	`/test e2e-agent-compact-ipv4-appliance-diskimage`
ci/prow/e2e-azurestack	`b7c3925`	link	false	`/test e2e-azurestack`
ci/prow/e2e-agent-compact-ipv6-minimaliso	`b7c3925`	link	false	`/test e2e-agent-compact-ipv6-minimaliso`
ci/prow/e2e-azure-default-config	`b7c3925`	link	false	`/test e2e-azure-default-config`
ci/prow/e2e-metal-ipi-ovn-ipv6	`b7c3925`	link	true	`/test e2e-metal-ipi-ovn-ipv6`
ci/prow/e2e-metal-single-node-live-iso	`b7c3925`	link	false	`/test e2e-metal-single-node-live-iso`
ci/prow/gcp-custom-endpoints-proxy-wif	`b7c3925`	link	false	`/test gcp-custom-endpoints-proxy-wif`
ci/prow/e2e-agent-compact-ipv4	`b7c3925`	link	true	`/test e2e-agent-compact-ipv4`
ci/prow/e2e-metal-ipi-ovn-virtualmedia	`b7c3925`	link	false	`/test e2e-metal-ipi-ovn-virtualmedia`
ci/prow/e2e-metal-ipi-ovn	`b7c3925`	link	false	`/test e2e-metal-ipi-ovn`
ci/prow/e2e-agent-4control-ipv4	`b7c3925`	link	false	`/test e2e-agent-4control-ipv4`
ci/prow/e2e-agent-compact-ipv4-none-platform	`b7c3925`	link	false	`/test e2e-agent-compact-ipv4-none-platform`
ci/prow/e2e-gcp-custom-endpoints	`b7c3925`	link	false	`/test e2e-gcp-custom-endpoints`
ci/prow/e2e-agent-compact-ipv4-iso-no-registry	`b7c3925`	link	false	`/test e2e-agent-compact-ipv4-iso-no-registry`
ci/prow/e2e-azure-ovn	`b7c3925`	link	true	`/test e2e-azure-ovn`
ci/prow/unit	`b7c3925`	link	true	`/test unit`
ci/prow/e2e-metal-ovn-two-node-fencing	`b7c3925`	link	false	`/test e2e-metal-ovn-two-node-fencing`
ci/prow/e2e-agent-ha-dualstack	`b7c3925`	link	false	`/test e2e-agent-ha-dualstack`
ci/prow/e2e-gcp-default-config	`b7c3925`	link	false	`/test e2e-gcp-default-config`
ci/prow/e2e-gcp-xpn-dedicated-dns-project	`b7c3925`	link	false	`/test e2e-gcp-xpn-dedicated-dns-project`
ci/prow/e2e-agent-5control-ipv4	`b7c3925`	link	false	`/test e2e-agent-5control-ipv4`
ci/prow/e2e-openstack-proxy	`b7c3925`	link	false	`/test e2e-openstack-proxy`
ci/prow/e2e-metal-ovn-two-node-arbiter	`b7c3925`	link	false	`/test e2e-metal-ovn-two-node-arbiter`
ci/prow/e2e-nutanix-ovn	`b7c3925`	link	false	`/test e2e-nutanix-ovn`
ci/prow/e2e-gcp-custom-dns	`b7c3925`	link	false	`/test e2e-gcp-custom-dns`
ci/prow/e2e-metal-assisted	`b7c3925`	link	false	`/test e2e-metal-assisted`
ci/prow/e2e-openstack-ovn	`b7c3925`	link	true	`/test e2e-openstack-ovn`
ci/prow/azure-ovn-marketplace-images	`b7c3925`	link	false	`/test azure-ovn-marketplace-images`
ci/prow/e2e-aws-ovn	`b7c3925`	link	true	`/test e2e-aws-ovn`
ci/prow/e2e-gcp-xpn-custom-dns	`b7c3925`	link	false	`/test e2e-gcp-xpn-custom-dns`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

The latest ignition contains the API addtion to deploy confidential clusters. Signed-off-by: Alice Frosi <afrosi@redhat.com> Signed-off-by: Fangge Jin <fjin@redhat.com>

openshift-ci-robot · 2026-03-20T09:05:27Z

@fangge1212: This pull request references OCPSTRAT-2713 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature to target either version "4.22." or "openshift-4.22.", but it targets "openshift-5.0" instead.

Details

In response to this:

The latest ignition contains the API addtion to deploy confidential clusters.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rna-afk · 2026-03-20T17:41:43Z

Might want to run these tests. I'm thinking moving the draft state to open will trigger it. Ready if you are.

openshift-ci bot requested review from andfasano and eranco74 March 16, 2026 07:09

fangge1212 mentioned this pull request Mar 16, 2026

OCPSTRAT-2713: Add ConfidentialCluster to InstallConfig #10386

Open

fangge1212 force-pushed the ignition-3.6-bump branch 2 times, most recently from e046b7a to b7c3925 Compare March 16, 2026 08:15

fangge1212 marked this pull request as draft March 17, 2026 10:55

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 17, 2026

fangge1212 force-pushed the ignition-3.6-bump branch from b7c3925 to d078874 Compare March 18, 2026 09:03

Bump ignition from 3.2 to 3.6

0889fd9

The latest ignition contains the API addtion to deploy confidential clusters. Signed-off-by: Alice Frosi <afrosi@redhat.com> Signed-off-by: Fangge Jin <fjin@redhat.com>

fangge1212 force-pushed the ignition-3.6-bump branch from d078874 to 0889fd9 Compare March 20, 2026 09:03

fangge1212 changed the title ~~Bump ignition from 3.2 to 3.6~~ OCPSTRAT-2713: Bump ignition from 3.2 to 3.6 Mar 20, 2026

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 20, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPSTRAT-2713: Bump ignition from 3.2 to 3.6#10392

OCPSTRAT-2713: Bump ignition from 3.2 to 3.6#10392
fangge1212 wants to merge 1 commit intoopenshift:mainfrom
fangge1212:ignition-3.6-bump

fangge1212 commented Mar 16, 2026

Uh oh!

coderabbitai bot commented Mar 16, 2026 •

edited

Loading

Review skipped

Uh oh!

openshift-ci bot commented Mar 16, 2026

Uh oh!

openshift-ci bot commented Mar 16, 2026

Uh oh!

openshift-ci-robot commented Mar 20, 2026 •

edited by openshift-ci bot

Loading

Uh oh!

rna-afk commented Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

fangge1212 commented Mar 16, 2026

Uh oh!

coderabbitai bot commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Estimated code review effort

Uh oh!

openshift-ci bot commented Mar 16, 2026

Uh oh!

openshift-ci bot commented Mar 16, 2026

Uh oh!

openshift-ci-robot commented Mar 20, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rna-afk commented Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai bot commented Mar 16, 2026 •

edited

Loading

openshift-ci-robot commented Mar 20, 2026 •

edited by openshift-ci bot

Loading