OCPBUGS-74528: upkeep: remove tna feature gate

[eggfoobar]

TNA (two node arbiter) has been GA for the past couple of releases, this is no longer needed as it is supported as part of the platform by default, and the feature gate will be removed from the API entirely.

API PR update
openshift/api#2759

[openshift-ci-robot]

@eggfoobar: This pull request references Jira Issue OCPBUGS-74528, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jogeo

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

TNA (two node arbiter) has been GA for the past couple of releases, this is no longer needed as it is supported as part of the platform by default, and the feature gate will be removed from the API entirely.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 04ea8524-8407-4705-a0e9-6eb46529150b

📥 Commits

Reviewing files that changed from the base of the PR and between 1896803 and 580187b.

📒 Files selected for processing (2)

• pkg/asset/agent/installconfig.go
• pkg/types/validation/installconfig.go

---

Walkthrough

The changes remove feature gate enforcement for Arbiter functionality in installation configuration and validation. Arbiter validation and configuration are now unconditionally processed without requiring the FeatureGateHighlyAvailableArbiter gate to be enabled.

Changes

Cohort / File(s)	Summary
Arbiter Feature Gate Removal pkg/asset/agent/installconfig.go, pkg/types/validation/installconfig.go	Removed FeatureGateHighlyAvailableArbiter gate checks, making Arbiter validation and the "2 (with arbiter)" configuration option available unconditionally. Eliminated conditional feature gate logic and removed the features import dependency.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

📝 Coding Plan

• Generate coding plan for human review comments

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.3)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[eggfoobar]

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-arbiter

[openshift-ci]

@eggfoobar: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-arbiter

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4ade3be0-2237-11f1-8737-6892152f2902-0

[tthvo]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tthvo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [tthvo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[eggfoobar]

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-agent-ovn-two-node-arbiter

[openshift-ci]

@eggfoobar: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-4.22-e2e-agent-ovn-two-node-arbiter

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ff4a28f0-27ff-11f1-9843-d44cc06f7e21-0

[eggfoobar]

/verified by https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-installer-10403-nightly-4.22-e2e-metal-ovn-two-node-arbiter/2033988548276785152 and https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-installer-10403-nightly-4.22-e2e-agent-ovn-two-node-arbiter/2036655957827653632

[openshift-ci-robot]

@eggfoobar: This PR has been marked as verified by https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-installer-10403-nightly-4.22-e2e-metal-ovn-two-node-arbiter/2033988548276785152 and https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-installer-10403-nightly-4.22-e2e-agent-ovn-two-node-arbiter/2036655957827653632.

Details

In response to this:

/verified by https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-installer-10403-nightly-4.22-e2e-metal-ovn-two-node-arbiter/2033988548276785152 and https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-installer-10403-nightly-4.22-e2e-agent-ovn-two-node-arbiter/2036655957827653632

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[eggfoobar]

/retest-required

[tthvo]

/test artifacts-images

[openshift-ci]

@eggfoobar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@eggfoobar: Jira Issue OCPBUGS-74528: Some pull requests linked via external trackers have merged:

• openshift/api#2759
• openshift/installer#10403

The following pull request, linked via external tracker, has not merged:

• openshift/cluster-config-operator#475 is open

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-74528 has not been moved to the MODIFIED state.

This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload.

Details

In response to this:

TNA (two node arbiter) has been GA for the past couple of releases, this is no longer needed as it is supported as part of the platform by default, and the feature gate will be removed from the API entirely.

API PR update
openshift/api#2759

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.