Skip to content

NO-ISSUE: Bump golang.org/x/crypto to v0.52.0#10697

Open
jkaurredhat wants to merge 1 commit into
openshift:mainfrom
jkaurredhat:update-xcrypto-main
Open

NO-ISSUE: Bump golang.org/x/crypto to v0.52.0#10697
jkaurredhat wants to merge 1 commit into
openshift:mainfrom
jkaurredhat:update-xcrypto-main

Conversation

@jkaurredhat

@jkaurredhat jkaurredhat commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR addresses CVE-2026-39828 by bumping golang.org/x/crypto from v0.48.0 to v0.52.0, which includes a fix for an unauthorized command execution vulnerability in the SSH server implementation.

Changes

  • Updated golang.org/x/crypto from v0.48.0 to v0.52.0
  • Updated transitive dependencies: golang.org/x/net, golang.org/x/sys, golang.org/x/term, golang.org/x/text, golang.org/x/tools
  • Ran go mod tidy and go mod vendor
  • Updated vendor directory with security patches

This update addresses CVE-2026-39828 (golang.org/x/crypto/ssh unauthorized
command execution vulnerability).

When an SSH server authentication callback returned PartialSuccessError
with non-nil Permissions, those permissions were silently discarded,
potentially dropping certificate restrictions such as force-command after
a second factor succeeded. This fix changes the behavior so that returning
non-nil Permissions with PartialSuccessError now results in a connection
error instead of silently discarding the permissions.

Updated golang.org/x/crypto from v0.48.0 to v0.52.0 to address this
security issue.
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

Updates pinned versions for several golang.org/x Go modules in go.mod; x/oauth2 and x/time remain unchanged. No exported declarations or implementation code are modified.

Changes

Go module dependency updates

Layer / File(s) Summary
Update golang.org/x dependency pins
go.mod
Bumps versions for x/crypto, x/sync, x/sys, x/term, x/text, x/mod, x/net, and x/tools while retaining existing x/oauth2 and x/time pins.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related issues

  • openshift/oauth-server#206 — Updates golang.org/x/crypto in go.mod.
  • openshift/image-based-install-operator#443 — Updates golang.org/x/crypto alongside other Go modules.
  • openshift/installer#10170 — Directly modifies the golang.org/x/crypto version.
  • openshift/origin#30621 — Updates golang.org/x/crypto in go.mod.
  • openshift/oc-mirror#1330 — Updates golang.org/x/crypto among other Go dependencies.
  • openshift/machine-config-operator#5506 — Updates the golang.org/x/crypto dependency.

Possibly related PRs

Suggested labels: acknowledge-critical-fixes-only

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed No test files changed and no Ginkgo title additions appear in the diff; this PR is vendor/dependency-only.
Test Structure And Quality ✅ Passed No Ginkgo test files or test code changed; this PR only updates go.mod, go.sum, and vendored dependencies.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests or test files were added; the PR only updates go.mod/go.sum and vendored deps.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests were added; the PR only updates go.mod/go.sum and vendored deps, so SNO compatibility isn’t impacted.
Topology-Aware Scheduling Compatibility ✅ Passed Only go.mod/go.sum and vendor updates were changed; no deployment manifests, operators, or controllers with scheduling constraints were modified.
Ote Binary Stdout Contract ✅ Passed Diff is vendor-only; no new stdout writes in main/init/suite setup. cpu.go prints predate the PR, and added log.Printf uses stderr by default.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only go.mod/go.sum and vendored deps changed; no new Ginkgo e2e tests or network assumptions were added.
No-Weak-Crypto ✅ Passed No weak-crypto or custom-crypto code was added in the diff; only dependency bumps and unrelated cipher fixes changed.
Container-Privileges ✅ Passed PR only changes go.mod/go.sum and vendored Go code; no container/K8s manifests with privilege settings were modified.
No-Sensitive-Data-In-Logs ✅ Passed No new sensitive logging was added; the only log.Printf found was a moved http2 verbose logger, not a new exposure.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: bumping golang.org/x/crypto to v0.52.0.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@jkaurredhat jkaurredhat changed the title Bump golang.org/x/crypto to v0.52.0 NO-ISSUE: Bump golang.org/x/crypto to v0.52.0 Jul 20, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 20, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@jkaurredhat: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

This PR addresses CVE-2026-39828 by bumping golang.org/x/crypto from v0.48.0 to v0.52.0, which includes a fix for an unauthorized command execution vulnerability in the SSH server implementation.

Changes

  • Updated golang.org/x/crypto from v0.48.0 to v0.52.0
  • Updated transitive dependencies: golang.org/x/net, golang.org/x/sys, golang.org/x/term, golang.org/x/text, golang.org/x/tools
  • Ran go mod tidy and go mod vendor
  • Updated vendor directory with security patches

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from barbacbd and rna-afk July 20, 2026 14:06
@openshift-ci

openshift-ci Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sdodson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

@jkaurredhat: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images b4b1d11 link true /test images
ci/prow/artifacts-images b4b1d11 link true /test artifacts-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tthvo

tthvo commented Jul 20, 2026

Copy link
Copy Markdown
Member

I think this PR may be a duplicate because golang.org/x/crypto is already on v0.52.0, right? 👀

golang.org/x/crypto v0.52.0

@tthvo

tthvo commented Jul 21, 2026

Copy link
Copy Markdown
Member

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants