[release-4.22] Bug OCPBUGS-99399: baremetal: fix provisioning ISO kernel arguments by jacob-anders · Pull Request #10703 · openshift/installer

jacob-anders · 2026-07-22T03:25:22Z

The provisioning ISO was missing ip=dhcp, causing bare metal nodes to fail to obtain an IP on the provisioning network. Additionally, console=ttyS0 without baud/parity data was causing lockups on some hardware.

Add ip=dhcp to the kernel arguments and specify baud rate and parity for serial console devices. Also append a trailing newline to preserve the COREOS_KARG_EMBED_AREA boundary for downstream consumers.

openshift-merge-bot · 2026-07-22T03:25:25Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

coderabbitai · 2026-07-22T03:25:30Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 99b06ebe-897d-4f06-8471-95f8b06335f4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

jacob-anders · 2026-07-22T07:03:37Z

/test images

openshift-ci-robot · 2026-07-22T07:04:21Z

@jacob-anders: This pull request references Jira Issue OCPBUGS-99399, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected dependent Jira Issue OCPBUGS-98696 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The provisioning ISO was missing ip=dhcp, causing bare metal nodes to fail to obtain an IP on the provisioning network. Additionally, console=ttyS0 without baud/parity data was causing lockups on some hardware.

Add ip=dhcp to the kernel arguments and specify baud rate and parity for serial console devices. Also append a trailing newline to preserve the COREOS_KARG_EMBED_AREA boundary for downstream consumers.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jacob-anders · 2026-07-22T07:06:57Z

/test unit

jacob-anders · 2026-07-22T07:11:35Z

/jira refresh

openshift-ci-robot · 2026-07-22T07:11:40Z

@jacob-anders: This pull request references Jira Issue OCPBUGS-99399, which is invalid:

expected dependent Jira Issue OCPBUGS-98696 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jacob-anders · 2026-07-22T07:59:02Z

/pipeline required

openshift-merge-bot · 2026-07-22T07:59:04Z

Scheduling required tests:
/test e2e-azure-nat-gateway-single-zone

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-metal-assisted
/test e2e-metal-ipi-ovn
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-ipv6
/test e2e-metal-ipi-ovn-swapped-hosts
/test e2e-metal-ipi-ovn-virtualmedia
/test e2e-metal-ovn-two-node-arbiter
/test e2e-metal-ovn-two-node-fencing
/test e2e-metal-single-node-live-iso
/test e2e-aws-ovn

elfosardo · 2026-07-22T08:00:11Z

/approve

openshift-ci · 2026-07-22T08:02:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~pkg/infrastructure/baremetal/OWNERS~~ [elfosardo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jacob-anders · 2026-07-22T09:30:33Z

/pipeline required

openshift-merge-bot · 2026-07-22T09:30:36Z

Scheduling required tests:
/test e2e-azure-nat-gateway-single-zone

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-metal-assisted
/test e2e-metal-ipi-ovn
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-ipv6
/test e2e-metal-ipi-ovn-swapped-hosts
/test e2e-metal-ipi-ovn-virtualmedia
/test e2e-metal-ovn-two-node-arbiter
/test e2e-metal-ovn-two-node-fencing
/test e2e-metal-single-node-live-iso
/test e2e-aws-ovn

MahnoorAsghar · 2026-07-22T15:10:27Z

/retest
Failures look unrelated

openshift-ci · 2026-07-22T19:51:12Z

@jacob-anders: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-single-node-live-iso	`c9902e5`	link	false	`/test e2e-metal-single-node-live-iso`
ci/prow/e2e-metal-ipi-ovn-swapped-hosts	`c9902e5`	link	false	`/test e2e-metal-ipi-ovn-swapped-hosts`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

jacob-anders · 2026-07-24T04:03:11Z

/test e2e-metal-ipi-ovn-ipv6

Add explicit baud/parity (115200n8) to the console karg on the bootstrap live ISO. Without baud/parity, the kernel defaults to 9600n8 which causes lockups on some hardware. Extract kargs construction into buildBootstrapKargs() with table-driven unit tests covering all architectures, FIPS, and trailing newline. Assisted-By: Claude Opus 4.6

openshift-ci Bot requested review from dtantsur and honza July 22, 2026 03:25

jacob-anders changed the title ~~[DNM][release-4.22]baremetal: fix provisioning ISO kernel arguments~~ [release-4.22]baremetal: fix provisioning ISO kernel arguments Jul 22, 2026

jacob-anders changed the title ~~[release-4.22]baremetal: fix provisioning ISO kernel arguments~~ [release-4.22] Bug OCPBUGS-99399: baremetal: fix provisioning ISO kernel arguments Jul 22, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2026

jacob-anders force-pushed the fix-provisioning-iso-kargs-4.22 branch from 677b3b2 to c9902e5 Compare July 22, 2026 09:29

jacob-anders force-pushed the fix-provisioning-iso-kargs-4.22 branch from c9902e5 to 87039fd Compare July 24, 2026 05:37

sgoveas added a commit to sgoveas/release that referenced this pull request Jul 24, 2026

test openshift/installer#10703

f98bc29

Uh oh!

Conversation

jacob-anders commented Jul 22, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 22, 2026

Uh oh!

coderabbitai Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

jacob-anders commented Jul 22, 2026

Uh oh!

openshift-ci-robot commented Jul 22, 2026

Uh oh!

jacob-anders commented Jul 22, 2026

Uh oh!

jacob-anders commented Jul 22, 2026

Uh oh!

openshift-ci-robot commented Jul 22, 2026

Uh oh!

jacob-anders commented Jul 22, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 22, 2026

Uh oh!

elfosardo commented Jul 22, 2026

Uh oh!

openshift-ci Bot commented Jul 22, 2026

Uh oh!

jacob-anders commented Jul 22, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 22, 2026

Uh oh!

MahnoorAsghar commented Jul 22, 2026

Uh oh!

openshift-ci Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jacob-anders commented Jul 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coderabbitai Bot commented Jul 22, 2026 •

edited

Loading

openshift-ci Bot commented Jul 22, 2026 •

edited

Loading