OCPBUGS-94441: upgrade CLOUDSDK_PYTHON to python3.11 in upi-installer#10715
OCPBUGS-94441: upgrade CLOUDSDK_PYTHON to python3.11 in upi-installer#10715savio87 wants to merge 2 commits into
Conversation
|
@savio87: This pull request references Jira Issue OCPBUGS-94441, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughChangesPython 3.11 UPI CI image
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @savio87. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
images/installer/Dockerfile.upi.ci (1)
56-63: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winInstall
python3.11-pipfor the versionedpip3.11commands.RHEL 9 installs
python3-pipfor the default Python 3 environment, whilepython3.11-pipprovides/usr/bin/pip3.11used by lines 77 and 83. Replacepython3-pipwithpython3.11-pip, or runpython3.11 -m pipif no separate package is desired.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@images/installer/Dockerfile.upi.ci` around lines 56 - 63, Update the package list in the Dockerfile’s dependency installation block to install python3.11-pip instead of python3-pip, ensuring the pip3.11 commands used later in the image build resolve correctly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@images/installer/Dockerfile.upi.ci`:
- Line 77: Update both pip3.11 install commands in the Dockerfile to include the
--no-cache-dir option, ensuring neither installation retains pip cache data in
the final image.
---
Outside diff comments:
In `@images/installer/Dockerfile.upi.ci`:
- Around line 56-63: Update the package list in the Dockerfile’s dependency
installation block to install python3.11-pip instead of python3-pip, ensuring
the pip3.11 commands used later in the image build resolve correctly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: f19af0ae-de3c-40db-9c49-a7de7295795d
📒 Files selected for processing (1)
images/installer/Dockerfile.upi.ci
|
Note: The Jira bot flagged OCPBUGS-94441 as invalid because it doesn't have a target version set. I don't have permissions to update the target version on the Jira issue. Could a maintainer set the target version to 5.0.0 on OCPBUGS-94441? I can then comment /jira refresh to re-validate. |
Summary
Fixes https://issues.redhat.com/browse/OCPBUGS-94441
Details
The upi-installer image sets CLOUDSDK_PYTHON=/usr/bin/python (Python 3.9 on RHEL 9). The Google Cloud CLI no longer supports Python 3.9, producing deprecation warnings before every gcloud command. This change installs python3.11, updates the CLOUDSDK_PYTHON env var, and switches pip install commands from pip-3 to pip3.11.
Test plan
Summary by CodeRabbit