Skip to content

SPLAT-2045: [vsphere] promote multi-nic to default #9493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rvanderp3
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 17, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 17, 2025

@rvanderp3: This pull request references SPLAT-2045 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rvanderp3
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 13, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2025
@rvanderp3
Copy link
Contributor Author

/payload-job-with-prs pull-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-multi-network-tech-preview openshift/api#2204
/payload-job-with-prs pull-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-multi-network openshift/api#2204

Copy link
Contributor

openshift-ci bot commented Mar 31, 2025

@rvanderp3: given command is invalid: at least one of the commands given is only supported on a one-command-per-comment basis, please separate out commands as multiple comments

@rvanderp3
Copy link
Contributor Author

/payload-job-with-prs pull-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-multi-network-tech-preview openshift/api#2204

Copy link
Contributor

openshift-ci bot commented Mar 31, 2025

@rvanderp3: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@rvanderp3
Copy link
Contributor Author

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-multi-network-tech-preview openshift/api#2204

Copy link
Contributor

openshift-ci bot commented Mar 31, 2025

@rvanderp3: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

@rvanderp3
Copy link
Contributor Author

/payload-job-with-prs pull-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-multi-network-tech-preview openshift/api#2204

Copy link
Contributor

openshift-ci bot commented Apr 3, 2025

@rvanderp3: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@rvanderp3
Copy link
Contributor Author

/payload-job-with-prs pull-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-multi-network-tech-preview openshift/api#2204

Copy link
Contributor

openshift-ci bot commented Apr 3, 2025

@rvanderp3: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

@rvanderp3
Copy link
Contributor Author

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-multi-network openshift/api#2204

Copy link
Contributor

openshift-ci bot commented Apr 3, 2025

@rvanderp3: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-multi-network

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e63e99d0-1091-11f0-815a-95d1230ecb0a-0

@rvanderp3
Copy link
Contributor Author

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-multi-network openshift/api#2204

Copy link
Contributor

openshift-ci bot commented Apr 3, 2025

@rvanderp3: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-multi-network

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/659390a0-10b5-11f0-8279-b4f2deeb2bab-0

Copy link
Contributor

openshift-ci bot commented Apr 3, 2025

@rvanderp3: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/openstack-manifests a7673e6b8cabfbb86d95b4fad1eeb0d583ef86cf link true /test openstack-manifests
ci/prow/e2e-openstack-nfv-intel a7673e6b8cabfbb86d95b4fad1eeb0d583ef86cf link false /test e2e-openstack-nfv-intel
ci/prow/e2e-aws-ovn-edge-zones 0b43541 link false /test e2e-aws-ovn-edge-zones
ci/prow/e2e-aws-ovn-heterogeneous 0b43541 link false /test e2e-aws-ovn-heterogeneous
ci/prow/images 0b43541 link true /test images
ci/prow/unit 0b43541 link true /test unit
ci/prow/e2e-azure-ovn-resourcegroup 0b43541 link false /test e2e-azure-ovn-resourcegroup
ci/prow/aro-unit 0b43541 link true /test aro-unit
ci/prow/azure-ovn-marketplace-images 0b43541 link false /test azure-ovn-marketplace-images
ci/prow/e2e-aws-ovn-edge-zones-manifest-validation 0b43541 link true /test e2e-aws-ovn-edge-zones-manifest-validation
ci/prow/e2e-aws-default-config 0b43541 link false /test e2e-aws-default-config
ci/prow/e2e-azure-ovn-shared-vpc 0b43541 link false /test e2e-azure-ovn-shared-vpc
ci/prow/e2e-azure-default-config 0b43541 link false /test e2e-azure-default-config
ci/prow/e2e-aws-ovn-shared-vpc-custom-security-groups 0b43541 link false /test e2e-aws-ovn-shared-vpc-custom-security-groups
ci/prow/e2e-vsphere-ovn-multi-network 0b43541 link false /test e2e-vsphere-ovn-multi-network
ci/prow/e2e-aws-ovn-fips 0b43541 link false /test e2e-aws-ovn-fips
ci/prow/e2e-azurestack 0b43541 link false /test e2e-azurestack
ci/prow/e2e-aws-ovn-shared-vpc-edge-zones 0b43541 link false /test e2e-aws-ovn-shared-vpc-edge-zones
ci/prow/e2e-aws-ovn-imdsv2 0b43541 link false /test e2e-aws-ovn-imdsv2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@WenXinWei
Copy link
Contributor

/approve

@WenXinWei
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2025
Copy link
Contributor

openshift-ci bot commented Apr 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: WenXinWei
Once this PR has been reviewed and has the lgtm label, please assign zaneb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants