Skip to content

[wip] Azure multi disk #9706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

[wip] Azure multi disk #9706

wants to merge 4 commits into from

Conversation

jcpowermac
Copy link
Contributor

Will add details later

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 12, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 12, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jhixson74 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jcpowermac
Copy link
Contributor Author 

controlPlane:                                                                                                       
  architecture: amd64                                                                                               
  hyperthreading: Enabled                                                                                           
  name: master                                                                                                      
  dataDisks:                                                                                                        
  - type: etcd                                                                                                      
    etcd:                                                                                                           
      platformDiskID: "etcddisk"                                                                                    
  platform:                                                                                                         
    azure:                                                            
      dataDisks:                                                                                                    
      - nameSuffix: etcddisk                                                                                        
        diskSizeGB: 256                                                                                             
        lun: 0                                                                                                      
  replicas: 3

jcpowermac
jcpowermac commented May 16, 2025
View reviewed changes
pkg/asset/ignition/machine/master.go
@@ -93,3 +112,42 @@ func (a *Master) Load(f asset.FileFetcher) (found bool, err error) {
a.File, a.Config = file, config
return true, nil
}

func AddEtcdDisk(config *igntypes.Config, device string) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuqi-zhang @patrickdillon suggested that I get your opinion on these changes. When you have a moment can you take a look?

We are starting an enhancement too but it isn't ready for a PR just yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jcpowermac