Skip to content

WIP: Add group snapshot featuregate #2238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

WIP: Add group snapshot featuregate #2238

wants to merge 2 commits into from

Conversation

jsafrane
Copy link

@jsafrane jsafrane commented Mar 7, 2025 •
edited
Loading

Testing adding tests for VolumeGroupSnapshot feature and its filtering with both [OCPFeatureGate:VolumeGroupSnapshot] and [FeatureGate:VolumeGroupSnapshot]. The tests should run only in TechPreviewNoUpgrade jobs.

jsafrane added 2 commits March 6, 2025 15:25
@jsafrane
UPSTREAM: <carry>: Add volume group snapshot test driver
2c92b71 
Upstream enables volume group snapshots by editing yaml files in a shell
script [1]. We can't use this script in openshift-tests.

Create a brand new, OCP specific test driver based on csi-driver-hostpath,
only with the --feature-gate=VolumeGroupSnapshot on external-snapshotter command line.

We will need to carry this patch until the feature graduates to GA. I've
chosen to create brand new files in this carry patch, so it can't conflict
with the existing ones.

1: https://github.com/kubernetes/kubernetes/blob/91d6fd3455c4a071408df20c7f48df221f2b6d30/test/e2e/testing-manifests/storage-csi/external-snapshotter/volume-group-snapshots/run_group_snapshot_e2e.sh
@jsafrane
UPSTREAM: <carry>: Use FeatureGate to filter tests
e1626d8
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Mar 7, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 7, 2025
@openshift-ci-robot
Copy link

@jsafrane: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from bertinatto and p0lyn0mial March 7, 2025 09:11
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jsafrane
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 7, 2025

@jsafrane: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-runc e1626d8 link true /test e2e-aws-ovn-runc
ci/prow/e2e-aws-ovn-cgroupsv2 e1626d8 link true /test e2e-aws-ovn-cgroupsv2
ci/prow/integration e1626d8 link true /test integration
ci/prow/e2e-aws-ovn-crun e1626d8 link true /test e2e-aws-ovn-crun
ci/prow/okd-scos-e2e-aws-ovn e1626d8 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-crun-wasm e1626d8 link true /test e2e-aws-crun-wasm
ci/prow/verify e1626d8 link true /test verify
ci/prow/e2e-aws-ovn-fips e1626d8 link true /test e2e-aws-ovn-fips
ci/prow/k8s-e2e-gcp-ovn e1626d8 link true /test k8s-e2e-gcp-ovn
ci/prow/e2e-gcp e1626d8 link true /test e2e-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 16, 2025
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto Awaiting requested review from bertinatto

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

Assignees
No one assigned
Labels
backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsafrane @openshift-ci-robot @openshift-merge-robot