Skip to content

CNTRLPLANE-179 apiserver library go bump #2285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CNTRLPLANE-179 apiserver library go bump #2285

wants to merge 1 commit into from

Conversation

ibihim
Copy link

@ibihim ibihim commented May 6, 2025 •
edited
Loading

What

Bumps apiserver-library-go

Why

  • Contains a new annotation that highlights the origin of the SCC assigned: user / service-account.
  • Some small refactoring for improved readability.

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label May 6, 2025
@openshift-ci-robot
Copy link

@ibihim: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@ibihim ibihim changed the title CNTRLPLANE-179 apiserver library go bump [WIP] CNTRLPLANE-179 apiserver library go bump May 6, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2025
@openshift-ci openshift-ci bot requested review from bertinatto and deads2k May 6, 2025 09:52
@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label May 6, 2025
@ibihim ibihim force-pushed the ibihim/2025-05-06_CNTRLPLANE-179-apiserver-library-go-bump branch from 9a06878 to 694cba2 Compare May 6, 2025 12:11
@openshift-ci-robot
Copy link

@ibihim: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@ibihim ibihim force-pushed the ibihim/2025-05-06_CNTRLPLANE-179-apiserver-library-go-bump branch from 694cba2 to 13836dc Compare May 6, 2025 12:12
@openshift-ci-robot
Copy link

@ibihim: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@ibihim
Copy link
Author

ibihim commented May 7, 2025

/retest-required

4 similar comments
@ibihim
Copy link
Author

ibihim commented May 7, 2025

/retest-required

@ibihim
Copy link
Author

ibihim commented May 8, 2025

/retest-required

@ibihim
Copy link
Author

ibihim commented May 12, 2025

/retest-required

@ibihim
Copy link
Author

ibihim commented May 12, 2025

/retest-required

@ibihim ibihim changed the title [WIP] CNTRLPLANE-179 apiserver library go bump CNTRLPLANE-179 apiserver library go bump May 13, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2025
@ibihim
Copy link
Author

ibihim commented May 13, 2025

/test okd-scos-e2e-aws-ovn

1 similar comment
@ibihim
Copy link
Author

ibihim commented May 15, 2025

/test okd-scos-e2e-aws-ovn

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 15, 2025

@ibihim: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ibihim ibihim mentioned this pull request May 15, 2025
Open
bertinatto
bertinatto reviewed May 16, 2025
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/remove-label backports/unvalidated-commits
/label backports/validated-commits

@openshift-ci openshift-ci bot added backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels May 16, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, ibihim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto bertinatto left review comments

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@bertinatto bertinatto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ibihim @openshift-ci-robot @bertinatto