Skip to content

update fbcs with TP bundles and fix dup in makefile #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update fbcs with TP bundles and fix dup in makefile #292

wants to merge 1 commit into from

Conversation

cpmeadors
Copy link
Contributor

update fbcs with TP bundles and fix dup in makefile

@openshift-ci openshift-ci bot requested review from kannon92 and rphillips May 1, 2025 19:37
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpmeadors

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2025
kannon92
kannon92 reviewed May 1, 2025
View reviewed changes
fbc/v4.19/catalog/kueue-operator/catalog.json Outdated
"name": "operand-image",
"image": "registry.redhat.io/kueue-tech-preview/kueue-rhel9@sha256:d0d6c34952e3d60be62fe7add33aa7ae2b0ac5c1bd2592e319f4cc28b2a2783e"
"name": "",
"image": "quay.io/redhat-user-workloads/kueue-operator-tenant/kueue-bundle-1-0@sha256:f2a9b5c73dada8854786fe08e8576d8fab4b109617138822b95b262bec0d2ae0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a bad change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea. not expected. this is coming from the bundle. I installed the bundle directly and the pullspecs are using registry.redhat.io (in a mirrorset). I don't know what is going on.

kannon92
kannon92 reviewed May 1, 2025
View reviewed changes
fbc/v4.18/catalog/kueue-operator/catalog.json Outdated
"name": "operand-image",
"image": "registry.redhat.io/kueue-tech-preview/kueue-rhel9@sha256:d0d6c34952e3d60be62fe7add33aa7ae2b0ac5c1bd2592e319f4cc28b2a2783e"
"name": "",
"image": "quay.io/redhat-user-workloads/kueue-operator-tenant/kueue-bundle-1-0@sha256:f2a9b5c73dada8854786fe08e8576d8fab4b109617138822b95b262bec0d2ae0"
Copy link
Contributor

@kannon92 kannon92 May 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the inconsistency here?

quay versus registry.redhat

@cpmeadors
Copy link
Contributor Author

/hole

@cpmeadors cpmeadors force-pushed the update-fbcs-with-TP-builds branch from 4ff76ce to f6ba3da Compare May 1, 2025 23:05
@kannon92
Copy link
Contributor

kannon92 commented May 2, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 2, 2025
@cpmeadors cpmeadors force-pushed the update-fbcs-with-TP-builds branch from f6ba3da to 0632b19 Compare May 2, 2025 11:58
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 2, 2025

@cpmeadors: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test-e2e-upstream-4-17 0632b19 link true /test test-e2e-upstream-4-17

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannon92 kannon92 kannon92 left review comments

@rphillips rphillips Awaiting requested review from rphillips

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpmeadors @kannon92