OU-192: replace react-router and react-router-dom with react-router-dom-compat-v5 #273
Conversation
…er-dom-compat-v5 for transition to react-router v6 Signed-off-by: Jenny Zhu <[email protected]>
openshift-ci-robot
added
the
jira/valid-reference
|
@zhuje: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
|
/retest |
FYI I wasn't 100% sure if I can do a direct replacement like this. I think its okay becuase this isn't a React Native app (e.g.mobile app) we don't specifically need From a google search: "react-router provides the core routing functionality, while react-router-dom is specifically designed for web applications, offering DOM-aware components. react-router-dom re-exports everything from react-router, so importing directly from react-router-dom is sufficient for web projects." |
zhuje
changed the title
|
@zhuje: This pull request references OU-192 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| @@ -65,8 +65,6 @@ | |||
| "react": "17.0.2", | |||
| "react-dom": "17.0.2", | |||
| "react-helmet": "^6.1.0", | |||
| "react-router": "5.3.x", | |||
There was a problem hiding this comment.
We should include the compat package in our dependencies. Although it currently works since the @openshift-console/dynamic-plugin-sdk package requires it, it is better to be explicit with the packages we are using
There was a problem hiding this comment.
Good point. Added react-router-dom-v5-compat in latest push.
Signed-off-by: Jenny Zhu <[email protected]>
|
@zhuje: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
/label ux-approved |
openshift-ci
bot
added
the
ux-approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jgbernalp, zhuje The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
cc @etmurasaki |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
@zhuje: This pull request references OU-192 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Context
remove react-router and react-router-dom to be replaced by react-router-dom-compat-v5 for transition to react-router v6
OU-192
Related JIRA from /openshift/console changes
openshift/console#14957
Threads
Slack #observability-ui-interal thread
https://redhat-internal.slack.com/archives/C03EPFR2BAR/p1744392852882399
Slack #announce-console-plugins
https://redhat-internal.slack.com/archives/C032NLNEE8G/p1744391666020899