Skip to content

Conversation

@ngopalak-redhat
Copy link
Contributor

This README provides instructions for running disruptive e2e tests for the MCO Operator, including periodic jobs and manual execution on a cluster.

- What I did

Small readme change to help users run MCO disruptive tests. Its not a complete readme for the e2e tests. I expect sometime in the future this readme will improve.

- How to verify it

I used this process and it worked

- Description for the changelog

This README provides instructions for running e2e tests for the MCO Operator, including periodic jobs and manual execution on a cluster.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 2, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ngopalak-redhat
Once this PR has been reviewed and has the lgtm label, please assign umohnani8 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from djoshy and pablintino January 2, 2026 08:04
@ngopalak-redhat
Copy link
Contributor Author

/retest-required

Comment on lines +1 to +3
This folder contains e2e tests for the MCO Operator.

TODO: Add an overview.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This directory does contain the MCO's e2e tests, but a few different types. The tests in https://github.com/openshift/machine-config-operator/tree/main/test/extended & https://github.com/openshift/machine-config-operator/tree/main/test/extended-priv both have disruptive payload tests and many of the tests in the other directories run as presubmits on PRs. I think it would be most helpful to have one overarching README in this directory that details the different types of tests in different sections below.

I think it could be fair for us to let this README merge to give some background on how to run these tests & team MCO can come back and enhance it as a tech debt item.

I can make a tech debt card tomorrow AM, but tentatively I think some of the updates needed are:

  • Running tests from the MCO repo
  • Where to find all the job names
  • Filling in the objective section as you noted
  • Adding details on the other test types

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @isabella-janssen! This README is a starting point to help Node team members (and likely other teams making changes to MCO) run MCO disruptive tests on their PRs. As of today, these are the only tests that restart the node with different kubelet configs. With this Readme in place I can inform my team members to run this test before submitting MCO PRs.

@ngopalak-redhat
Copy link
Contributor Author

/test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 9, 2026

@ngopalak-redhat: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants