-
Notifications
You must be signed in to change notification settings - Fork 462
AGENT-1431: Backport InternalReleaseImage support #5610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-4.21
Are you sure you want to change the base?
Conversation
AGENT-1391: Use TLS cert for the InternalReleaseImage registry
…vice AGENT-1411: Preload the registry image when starting the iri-service
…y-file AGENT-1411: fix IRI registry setup file
AGENT-1424: add initial e2e tests for the InternalReleaseImage controller
|
@bfournie: This pull request references AGENT-1431 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bfournie The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This adds the minimal osimagestream.GetReleasePayloadImage() function needed to support PR openshift#5545 (AGENT-1412 IRI deletion guard) without requiring the full OSImageStream functionality from PR openshift#5476. This is a targeted backport to release-4.21 to enable the IRI deletion guard feature. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
…on-guard AGENT-1412: Prevent deletion of InternalReleaseImage when in use Add ValidatingAdmissionPolicy to block deletion of the InternalReleaseImage singleton resource if any of its release bundles are currently in use by the cluster. This prevents accidental deletion of IRI while the cluster is running a release version that is stored in the InternalReleaseImage resource. The policy checks the ClusterVersion's current version against all release bundle names in the IRI status. If a match is found, deletion is blocked with a clear error message instructing the user to upgrade or downgrade before deletion. This is part of the NoRegistryClusterInstall feature, where deletion of IRI is the default opt-out mechanism, and this guard ensures safe operation. Backported from upstream main with minimal osimagestream package support.
|
@bfournie: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@bfournie: This pull request references AGENT-1431 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
- What I did
This is a backport to add support for the InternalReleaseImage.
The following PRs have been backported:
#5483
#5514
#5543
#5588
#5545 (note that this change also required minimal
changes included for the addition of ClusterVersion in #5476)
- Description for the changelog
Backport InternalReleaseImage support