[release-4.21] OCPBUGS-78800: Re-order logger setting to eliminate race condition by openshift-cherrypick-robot · Pull Request #5779 · openshift/machine-config-operator

openshift-cherrypick-robot · 2026-03-18T18:47:38Z

This is an automated cherry-pick of #5691

/assign isabella-janssen

/cherrypick release-4.20 release-4.19

coderabbitai · 2026-03-18T18:47:47Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0f5b7aac-1071-4a73-b0be-6f548c3bcdf2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

isabella-janssen · 2026-03-19T12:52:12Z

/retest-required

isabella-janssen · 2026-03-19T13:59:18Z

/retitle [release-4.21] OCPBUGS-78800: Re-order logger setting to eliminate race condition

openshift-ci-robot · 2026-03-19T14:00:04Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-78800, which is invalid:

expected dependent Jira Issue OCPBUGS-74223 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #5691

/assign isabella-janssen

/cherrypick release-4.20 release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pablintino · 2026-03-20T11:03:39Z

/lgtm
/label backport-risk-assessed

openshift-ci · 2026-03-20T11:04:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [pablintino]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

isabella-janssen · 2026-03-20T18:45:16Z

/verified by @isabella-janssen

This PR was verified by launching a cluster with #5783 to force the race condition causing the bug to always occur.

Without this fix included, we see the error logs:

$ oc logs -n openshift-machine-config-operator -c machine-config-server machine-config-server-d589d
I0320 18:13:28.799567       1 start.go:40] Version: machine-config-daemon-4.6.0-202006240615.p0-3948-g21c5104a-dirty (21c5104a9c6ad301f11a5f6ae6384cf58bc0daac)
I0320 18:13:28.803628       1 envvar.go:172] "Feature gate default state" feature="ClientsAllowCBOR" enabled=false
I0320 18:13:28.803724       1 envvar.go:172] "Feature gate default state" feature="ClientsPreferCBOR" enabled=false
I0320 18:13:28.803762       1 envvar.go:172] "Feature gate default state" feature="InOrderInformers" enabled=true
I0320 18:13:28.803793       1 envvar.go:172] "Feature gate default state" feature="InformerResourceVersion" enabled=false
I0320 18:13:28.803824       1 envvar.go:172] "Feature gate default state" feature="WatchListClient" enabled=false
I0320 18:13:28.934645       1 reflector.go:436] "Caches populated" type="*v1.MachineConfigPool" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 18:13:28.935316       1 reflector.go:436] "Caches populated" type="*v1.MachineOSConfig" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 18:13:28.935687       1 reflector.go:436] "Caches populated" type="*v1.MachineOSBuild" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 18:13:28.945876       1 reflector.go:436] "Caches populated" type="*v1.ControllerConfig" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 18:13:28.946732       1 reflector.go:436] "Caches populated" type="*v1.ConfigMap" reflector="k8s.io/client-go/informers/factory.go:160"
I0320 18:13:28.961819       1 reflector.go:436] "Caches populated" type="*v1.MachineConfig" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 18:13:28.997740       1 start.go:51] Launching server with tls min version: VersionTLS12 & cipher suites [TLS_AES_128_GCM_SHA256 TLS_AES_256_GCM_SHA384 TLS_CHACHA20_POLY1305_SHA256 TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256 TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256]
I0320 18:13:28.998138       1 api.go:69] Launching server on :22624
I0320 18:13:28.998251       1 api.go:69] Launching server on :22623
[controller-runtime] log.SetLogger(...) was never called; logs will not be displayed.
Detected at:
	>  goroutine 131 [running]:
	>  runtime/debug.Stack()
	>  	/usr/lib/golang/src/runtime/debug/stack.go:26 +0x5e
	>  sigs.k8s.io/controller-runtime/pkg/log.eventuallyFulfillRoot()
	>  	/go/src/github.com/openshift/machine-config-operator/vendor/sigs.k8s.io/controller-runtime/pkg/log/log.go:60 +0xcd
	>  sigs.k8s.io/controller-runtime/pkg/log.(*delegatingLogSink).Enabled(0xc000591780, 0x0)
	>  	/go/src/github.com/openshift/machine-config-operator/vendor/sigs.k8s.io/controller-runtime/pkg/log/deleg.go:111 +0x32
	>  github.com/go-logr/logr.Logger.Info({{0x2d48070?, 0xc000591780?}, 0xc0007c1c00?}, {0x28eb32b, 0x1f}, {0x0, 0x0, 0x0})
	>  	/go/src/github.com/openshift/machine-config-operator/vendor/github.com/go-logr/logr/logr.go:276 +0x6e
	>  sigs.k8s.io/controller-runtime/pkg/certwatcher.(*CertWatcher).ReadCertificate(0xc0002e6230)
	>  	/go/src/github.com/openshift/machine-config-operator/vendor/sigs.k8s.io/controller-runtime/pkg/certwatcher/certwatcher.go:211 +0x29c
	>  sigs.k8s.io/controller-runtime/pkg/certwatcher.New({0x28d5d8b, 0x14}, {0x28d5d9f, 0x14})
	>  	/go/src/github.com/openshift/machine-config-operator/vendor/sigs.k8s.io/controller-runtime/pkg/certwatcher/certwatcher.go:71 +0x8f
	>  github.com/openshift/machine-config-operator/pkg/server.(*APIServer).Serve(0xc000592460)
	>  	/go/src/github.com/openshift/machine-config-operator/pkg/server/api.go:77 +0x2c8
	>  created by main.runStartCmd in goroutine 1
	>  	/go/src/github.com/openshift/machine-config-operator/cmd/machine-config-server/start.go:59 +0x37e
I0320 18:23:27.104095       1 api.go:129] Pool "worker" requested by address:"10.0.128.4:37828" User-Agent:"Ignition/2.21.0" Accept-Header: "application/vnd.coreos.ignition+json;version=3.5.0, */*;q=0.1"
I0320 18:24:38.798144       1 reflector.go:436] "Caches populated" type="*v1.MachineOSConfig" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 18:24:39.226810       1 reflector.go:436] "Caches populated" type="*v1.MachineOSBuild" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 18:36:33.654990       1 reflector.go:436] "Caches populated" type="*v1.MachineConfigPool" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 18:36:34.374505       1 reflector.go:436] "Caches populated" type="*v1.MachineConfig" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 18:36:34.597109       1 reflector.go:436] "Caches populated" type="*v1.MachineOSBuild" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 18:36:35.362407       1 reflector.go:436] "Caches populated" type="*v1.ControllerConfig" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 18:36:35.793570       1 reflector.go:436] "Caches populated" type="*v1.MachineOSConfig" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"

With the fix included, there are no error logs:

$ oc logs -n openshift-machine-config-operator -c machine-config-server machine-config-server-crz5t
I0320 17:05:37.915436       1 start.go:44] Version: machine-config-daemon-4.6.0-202006240615.p0-3950-gd8ee868d-dirty (d8ee868d190641081babe13dd55224561d4e6713)
I0320 17:05:37.915859       1 envvar.go:172] "Feature gate default state" feature="InformerResourceVersion" enabled=false
I0320 17:05:37.915870       1 envvar.go:172] "Feature gate default state" feature="WatchListClient" enabled=false
I0320 17:05:37.915874       1 envvar.go:172] "Feature gate default state" feature="ClientsAllowCBOR" enabled=false
I0320 17:05:37.915879       1 envvar.go:172] "Feature gate default state" feature="ClientsPreferCBOR" enabled=false
I0320 17:05:37.915885       1 envvar.go:172] "Feature gate default state" feature="InOrderInformers" enabled=true
I0320 17:05:37.933259       1 reflector.go:436] "Caches populated" type="*v1.MachineOSConfig" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 17:05:37.933279       1 reflector.go:436] "Caches populated" type="*v1.MachineOSBuild" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 17:05:37.936930       1 reflector.go:436] "Caches populated" type="*v1.ConfigMap" reflector="k8s.io/client-go/informers/factory.go:160"
I0320 17:05:37.938034       1 reflector.go:436] "Caches populated" type="*v1.MachineConfigPool" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 17:05:37.939937       1 reflector.go:436] "Caches populated" type="*v1.ControllerConfig" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 17:05:37.956059       1 reflector.go:436] "Caches populated" type="*v1.MachineConfig" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 17:05:38.018658       1 start.go:55] Launching server with tls min version: VersionTLS12 & cipher suites [TLS_AES_128_GCM_SHA256 TLS_AES_256_GCM_SHA384 TLS_CHACHA20_POLY1305_SHA256 TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256 TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256]
I0320 17:05:38.018783       1 api.go:68] Launching server on :22624
I0320 17:05:38.018859       1 api.go:68] Launching server on :22623
I0320 17:06:13.020132       1 certwatcher.go:211] "Updated current TLS certificate" logger="controller-runtime.certwatcher"
I0320 17:06:13.020379       1 certwatcher.go:133] "Starting certificate poll+watcher" logger="controller-runtime.certwatcher" interval="10s"
I0320 17:16:19.650989       1 api.go:127] Pool "worker" requested by address:"10.0.128.2:50708" User-Agent:"Ignition/2.21.0" Accept-Header: "application/vnd.coreos.ignition+json;version=3.5.0, */*;q=0.1"
I0320 17:18:33.410374       1 reflector.go:436] "Caches populated" type="*v1.MachineConfig" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 17:18:33.471711       1 reflector.go:436] "Caches populated" type="*v1.MachineConfigPool" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 17:18:33.991254       1 reflector.go:436] "Caches populated" type="*v1.ControllerConfig" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 17:18:34.431928       1 reflector.go:436] "Caches populated" type="*v1.MachineOSConfig" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 17:18:34.435440       1 reflector.go:436] "Caches populated" type="*v1.MachineOSBuild" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 17:20:23.783974       1 reflector.go:436] "Caches populated" type="*v1.MachineOSConfig" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 17:23:32.367088       1 reflector.go:436] "Caches populated" type="*v1.MachineConfigPool" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 17:23:32.491269       1 reflector.go:436] "Caches populated" type="*v1.MachineOSConfig" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 17:23:33.357929       1 reflector.go:436] "Caches populated" type="*v1.MachineOSBuild" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 17:30:52.439510       1 reflector.go:436] "Caches populated" type="*v1.MachineOSBuild" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 17:30:52.594003       1 reflector.go:436] "Caches populated" type="*v1.MachineConfigPool" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 17:30:52.635693       1 reflector.go:436] "Caches populated" type="*v1.ControllerConfig" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 17:30:53.111341       1 reflector.go:436] "Caches populated" type="*v1.MachineConfig" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 17:30:53.611415       1 reflector.go:436] "Caches populated" type="*v1.MachineOSConfig" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"

openshift-ci-robot · 2026-03-20T18:45:28Z

@isabella-janssen: This PR has been marked as verified by @isabella-janssen.

Details

In response to this:

/verified by @isabella-janssen

This PR was verified by launching a cluster with #5783 to force the race condition causing the bug to always occur.

Without this fix included, we see the error logs:

oc logs -n openshift-machine-config-operator -c machine-config-server machine-config-server-d589d
I0320 18:13:28.799567       1 start.go:40] Version: machine-config-daemon-4.6.0-202006240615.p0-3948-g21c5104a-dirty (21c5104a9c6ad301f11a5f6ae6384cf58bc0daac)
I0320 18:13:28.803628       1 envvar.go:172] "Feature gate default state" feature="ClientsAllowCBOR" enabled=false
I0320 18:13:28.803724       1 envvar.go:172] "Feature gate default state" feature="ClientsPreferCBOR" enabled=false
I0320 18:13:28.803762       1 envvar.go:172] "Feature gate default state" feature="InOrderInformers" enabled=true
I0320 18:13:28.803793       1 envvar.go:172] "Feature gate default state" feature="InformerResourceVersion" enabled=false
I0320 18:13:28.803824       1 envvar.go:172] "Feature gate default state" feature="WatchListClient" enabled=false
I0320 18:13:28.934645       1 reflector.go:436] "Caches populated" type="*v1.MachineConfigPool" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 18:13:28.935316       1 reflector.go:436] "Caches populated" type="*v1.MachineOSConfig" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 18:13:28.935687       1 reflector.go:436] "Caches populated" type="*v1.MachineOSBuild" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 18:13:28.945876       1 reflector.go:436] "Caches populated" type="*v1.ControllerConfig" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 18:13:28.946732       1 reflector.go:436] "Caches populated" type="*v1.ConfigMap" reflector="k8s.io/client-go/informers/factory.go:160"
I0320 18:13:28.961819       1 reflector.go:436] "Caches populated" type="*v1.MachineConfig" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 18:13:28.997740       1 start.go:51] Launching server with tls min version: VersionTLS12 & cipher suites [TLS_AES_128_GCM_SHA256 TLS_AES_256_GCM_SHA384 TLS_CHACHA20_POLY1305_SHA256 TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256 TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256]
I0320 18:13:28.998138       1 api.go:69] Launching server on :22624
I0320 18:13:28.998251       1 api.go:69] Launching server on :22623
[controller-runtime] log.SetLogger(...) was never called; logs will not be displayed.
Detected at:
  >  goroutine 131 [running]:
  >  runtime/debug.Stack()
  >  	/usr/lib/golang/src/runtime/debug/stack.go:26 +0x5e
  >  sigs.k8s.io/controller-runtime/pkg/log.eventuallyFulfillRoot()
  >  	/go/src/github.com/openshift/machine-config-operator/vendor/sigs.k8s.io/controller-runtime/pkg/log/log.go:60 +0xcd
  >  sigs.k8s.io/controller-runtime/pkg/log.(*delegatingLogSink).Enabled(0xc000591780, 0x0)
  >  	/go/src/github.com/openshift/machine-config-operator/vendor/sigs.k8s.io/controller-runtime/pkg/log/deleg.go:111 +0x32
  >  github.com/go-logr/logr.Logger.Info({{0x2d48070?, 0xc000591780?}, 0xc0007c1c00?}, {0x28eb32b, 0x1f}, {0x0, 0x0, 0x0})
  >  	/go/src/github.com/openshift/machine-config-operator/vendor/github.com/go-logr/logr/logr.go:276 +0x6e
  >  sigs.k8s.io/controller-runtime/pkg/certwatcher.(*CertWatcher).ReadCertificate(0xc0002e6230)
  >  	/go/src/github.com/openshift/machine-config-operator/vendor/sigs.k8s.io/controller-runtime/pkg/certwatcher/certwatcher.go:211 +0x29c
  >  sigs.k8s.io/controller-runtime/pkg/certwatcher.New({0x28d5d8b, 0x14}, {0x28d5d9f, 0x14})
  >  	/go/src/github.com/openshift/machine-config-operator/vendor/sigs.k8s.io/controller-runtime/pkg/certwatcher/certwatcher.go:71 +0x8f
  >  github.com/openshift/machine-config-operator/pkg/server.(*APIServer).Serve(0xc000592460)
  >  	/go/src/github.com/openshift/machine-config-operator/pkg/server/api.go:77 +0x2c8
  >  created by main.runStartCmd in goroutine 1
  >  	/go/src/github.com/openshift/machine-config-operator/cmd/machine-config-server/start.go:59 +0x37e
I0320 18:23:27.104095       1 api.go:129] Pool "worker" requested by address:"10.0.128.4:37828" User-Agent:"Ignition/2.21.0" Accept-Header: "application/vnd.coreos.ignition+json;version=3.5.0, */*;q=0.1"
I0320 18:24:38.798144       1 reflector.go:436] "Caches populated" type="*v1.MachineOSConfig" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 18:24:39.226810       1 reflector.go:436] "Caches populated" type="*v1.MachineOSBuild" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 18:36:33.654990       1 reflector.go:436] "Caches populated" type="*v1.MachineConfigPool" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 18:36:34.374505       1 reflector.go:436] "Caches populated" type="*v1.MachineConfig" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 18:36:34.597109       1 reflector.go:436] "Caches populated" type="*v1.MachineOSBuild" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 18:36:35.362407       1 reflector.go:436] "Caches populated" type="*v1.ControllerConfig" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 18:36:35.793570       1 reflector.go:436] "Caches populated" type="*v1.MachineOSConfig" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"

With the fix included, there are no error logs:

oc logs -n openshift-machine-config-operator -c machine-config-server machine-config-server-crz5t
I0320 17:05:37.915436       1 start.go:44] Version: machine-config-daemon-4.6.0-202006240615.p0-3950-gd8ee868d-dirty (d8ee868d190641081babe13dd55224561d4e6713)
I0320 17:05:37.915859       1 envvar.go:172] "Feature gate default state" feature="InformerResourceVersion" enabled=false
I0320 17:05:37.915870       1 envvar.go:172] "Feature gate default state" feature="WatchListClient" enabled=false
I0320 17:05:37.915874       1 envvar.go:172] "Feature gate default state" feature="ClientsAllowCBOR" enabled=false
I0320 17:05:37.915879       1 envvar.go:172] "Feature gate default state" feature="ClientsPreferCBOR" enabled=false
I0320 17:05:37.915885       1 envvar.go:172] "Feature gate default state" feature="InOrderInformers" enabled=true
I0320 17:05:37.933259       1 reflector.go:436] "Caches populated" type="*v1.MachineOSConfig" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 17:05:37.933279       1 reflector.go:436] "Caches populated" type="*v1.MachineOSBuild" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 17:05:37.936930       1 reflector.go:436] "Caches populated" type="*v1.ConfigMap" reflector="k8s.io/client-go/informers/factory.go:160"
I0320 17:05:37.938034       1 reflector.go:436] "Caches populated" type="*v1.MachineConfigPool" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 17:05:37.939937       1 reflector.go:436] "Caches populated" type="*v1.ControllerConfig" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 17:05:37.956059       1 reflector.go:436] "Caches populated" type="*v1.MachineConfig" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 17:05:38.018658       1 start.go:55] Launching server with tls min version: VersionTLS12 & cipher suites [TLS_AES_128_GCM_SHA256 TLS_AES_256_GCM_SHA384 TLS_CHACHA20_POLY1305_SHA256 TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256 TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256]
I0320 17:05:38.018783       1 api.go:68] Launching server on :22624
I0320 17:05:38.018859       1 api.go:68] Launching server on :22623
I0320 17:06:13.020132       1 certwatcher.go:211] "Updated current TLS certificate" logger="controller-runtime.certwatcher"
I0320 17:06:13.020379       1 certwatcher.go:133] "Starting certificate poll+watcher" logger="controller-runtime.certwatcher" interval="10s"
I0320 17:16:19.650989       1 api.go:127] Pool "worker" requested by address:"10.0.128.2:50708" User-Agent:"Ignition/2.21.0" Accept-Header: "application/vnd.coreos.ignition+json;version=3.5.0, */*;q=0.1"
I0320 17:18:33.410374       1 reflector.go:436] "Caches populated" type="*v1.MachineConfig" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 17:18:33.471711       1 reflector.go:436] "Caches populated" type="*v1.MachineConfigPool" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 17:18:33.991254       1 reflector.go:436] "Caches populated" type="*v1.ControllerConfig" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 17:18:34.431928       1 reflector.go:436] "Caches populated" type="*v1.MachineOSConfig" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 17:18:34.435440       1 reflector.go:436] "Caches populated" type="*v1.MachineOSBuild" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 17:20:23.783974       1 reflector.go:436] "Caches populated" type="*v1.MachineOSConfig" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 17:23:32.367088       1 reflector.go:436] "Caches populated" type="*v1.MachineConfigPool" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 17:23:32.491269       1 reflector.go:436] "Caches populated" type="*v1.MachineOSConfig" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 17:23:33.357929       1 reflector.go:436] "Caches populated" type="*v1.MachineOSBuild" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 17:30:52.439510       1 reflector.go:436] "Caches populated" type="*v1.MachineOSBuild" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 17:30:52.594003       1 reflector.go:436] "Caches populated" type="*v1.MachineConfigPool" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 17:30:52.635693       1 reflector.go:436] "Caches populated" type="*v1.ControllerConfig" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 17:30:53.111341       1 reflector.go:436] "Caches populated" type="*v1.MachineConfig" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"
I0320 17:30:53.611415       1 reflector.go:436] "Caches populated" type="*v1.MachineOSConfig" reflector="github.com/openshift/client-go/machineconfiguration/informers/externalversions/factory.go:125"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

isabella-janssen · 2026-03-23T12:15:19Z

/jira refresh

openshift-ci-robot · 2026-03-23T12:15:26Z

@isabella-janssen: This pull request references Jira Issue OCPBUGS-78800, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.z) matches configured target version for branch (4.21.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-74223 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-74223 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
bug has dependents

Requesting review from QA contact:
/cc @sergiordlr

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

isabella-janssen · 2026-03-23T12:17:10Z

/retest-required

openshift-ci · 2026-03-23T15:05:25Z

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-op-ocl	`8430ba7`	link	false	`/test e2e-gcp-op-ocl`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

isabella-janssen · 2026-03-23T15:15:38Z

/retest-required

openshift-ci-robot · 2026-03-23T18:42:17Z

@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-78800
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-78800 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This is an automated cherry-pick of #5691

/assign isabella-janssen

/cherrypick release-4.20 release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot · 2026-03-23T18:43:19Z

@openshift-cherrypick-robot: new pull request created: #5791

Details

In response to this:

This is an automated cherry-pick of #5691

/assign isabella-janssen

/cherrypick release-4.20 release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

server: re-order logger setting

8430ba7

openshift-cherrypick-robot assigned isabella-janssen Mar 18, 2026

openshift-cherrypick-robot mentioned this pull request Mar 18, 2026

OCPBUGS-74223: Re-order logger setting to eliminate race condition #5691

Merged

openshift-ci bot requested review from pablintino and yuqi-zhang March 18, 2026 18:48

openshift-ci bot changed the title ~~[release-4.21] OCPBUGS-74223: Re-order logger setting to eliminate race condition~~ [release-4.21] OCPBUGS-78800: Re-order logger setting to eliminate race condition Mar 19, 2026

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 19, 2026

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 20, 2026

openshift-ci bot assigned anuragthehatter, imatza-rh, lyman9966, mhanss, ptalgulk01, rbbratta, rioliu-rh, sergiordlr and zhaozhanqi Mar 20, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2026

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 20, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 23, 2026

openshift-ci bot requested a review from sergiordlr March 23, 2026 12:15

openshift-merge-bot bot merged commit 066e88f into openshift:release-4.21 Mar 23, 2026
16 of 17 checks passed

openshift-cherrypick-robot mentioned this pull request Mar 23, 2026

[release-4.20] OCPBUGS-79370: Re-order logger setting to eliminate race condition #5791

Open

Conversation

openshift-cherrypick-robot commented Mar 18, 2026

Uh oh!

coderabbitai bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

isabella-janssen commented Mar 19, 2026

Uh oh!

isabella-janssen commented Mar 19, 2026

Uh oh!

openshift-ci-robot commented Mar 19, 2026

Uh oh!

pablintino commented Mar 20, 2026

Uh oh!

openshift-ci bot commented Mar 20, 2026

Uh oh!

isabella-janssen commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 20, 2026

Uh oh!

isabella-janssen commented Mar 23, 2026

Uh oh!

openshift-ci-robot commented Mar 23, 2026

Uh oh!

isabella-janssen commented Mar 23, 2026

Uh oh!

openshift-ci bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

isabella-janssen commented Mar 23, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 23, 2026

Uh oh!

openshift-cherrypick-robot commented Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

coderabbitai bot commented Mar 18, 2026 •

edited

Loading

isabella-janssen commented Mar 20, 2026 •

edited

Loading

openshift-ci bot commented Mar 23, 2026 •

edited

Loading