use progressive JSON unmarshalling for secret decoding#5787
use progressive JSON unmarshalling for secret decoding#5787cheesesashimi wants to merge 1 commit intoopenshift:mainfrom
Conversation
This adds additional test cases for K8s secret decoding since I ran into what I thought was a bug when trying to write additional test cases for the new SysContext helper. Assisted-By: Claude Sonnet 4.5
|
Skipping CI for Draft Pull Request. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheesesashimi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
- What I did
This refactors the DockerConfigJSON / DockerConfig secret decoding process to
an implementation which does partial JSON decoding before determining what to
do.
This adds additional test cases for K8s secret decoding since I ran into
what I thought was a bug when trying to write additional test cases for
the new SysContext helper.
- How to verify it
No behavioral changes should occur with this change, meaning that the E2E test suites should be able to exercise and validate this code path correctly.
- Description for the changelog
Use partial JSON decoding for secrets helper