Skip to content

[WIP] AGENT-1307: add MCD IRI manager#5807

Open
andfasano wants to merge 1 commit intoopenshift:mainfrom
andfasano:iri-mcd
Open

[WIP] AGENT-1307: add MCD IRI manager#5807
andfasano wants to merge 1 commit intoopenshift:mainfrom
andfasano:iri-mcd

Conversation

@andfasano
Copy link
Contributor

@andfasano andfasano commented Mar 25, 2026

- What I did
Added a new MachineConfigDaemon manager for InternalReleaseImage.
Currently it takes care of updating the node MachineConfigNode with the status of the local IRI registry

- How to verify it
Run the iso-no-registry CI job

- Description for the changelog
todo


Example of MCN update:

$ oc get machineconfignodes master-0 -o yaml    
apiVersion: machineconfiguration.openshift.io/v1                                       
kind: MachineConfigNode                                                                  
metadata:                    
  name: master-0   
...  
status:
...
  internalReleaseImage:
    releases:
    - conditions:
      - lastTransitionTime: "2026-03-25T18:09:31Z"
        message: Release ocp-release-bundle-4.22.0-x86_64 is currently available
        reason: Available
        status: "True"
        type: Available
      image: api-int.ostest.test.metalkube.org:22625/openshift/release-images@sha256:4b813d44e243b8150b0cef221de0ce8f798952abbb31bd56cf7b596c70e0d0f7
      name: ocp-release-bundle-4.22.0-x86_64

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 25, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 25, 2026

@andfasano: This pull request references AGENT-1307 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

- What I did
Added a new MachineConfigDaemon manager for InternalReleaseImage.
Currently it takes care of updating the node MachineConfigNode with the status of the local IRI registry

- How to verify it
Run the iso-no-registry CI job

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link

coderabbitai bot commented Mar 25, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e4bf65f0-b423-4c12-a26a-8f3bf991ddf2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 25, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andfasano
Once this PR has been reviewed and has the lgtm label, please assign umohnani8 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 25, 2026

@andfasano: This pull request references AGENT-1307 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

- What I did
Added a new MachineConfigDaemon manager for InternalReleaseImage.
Currently it takes care of updating the node MachineConfigNode with the status of the local IRI registry

- How to verify it
Run the iso-no-registry CI job

- Description for the changelog
todo


Example of MCN update:

$ oc get machineconfignodes master-0 -o yaml    
apiVersion: machineconfiguration.openshift.io/v1                                       
kind: MachineConfigNode                                                                  
metadata:                    
 name: master-0   
...  
status:
...
 internalReleaseImage:
   releases:
   - conditions:
     - lastTransitionTime: "2026-03-25T18:09:31Z"
       message: Release ocp-release-bundle-4.22.0-x86_64 is currently available
       reason: Available
       status: "True"
       type: Available
     image: api-int.ostest.test.metalkube.org:22625/openshift/release-images@sha256:4b813d44e243b8150b0cef221de0ce8f798952abbb31bd56cf7b596c70e0d0f7
     name: ocp-release-bundle-4.22.0-x86_64

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@andfasano
Copy link
Contributor Author

/test e2e-agent-compact-ipv4-iso-no-registry

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 26, 2026

@andfasano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify 01103a4 link true /test verify
ci/prow/e2e-agent-compact-ipv4-iso-no-registry 01103a4 link false /test e2e-agent-compact-ipv4-iso-no-registry
ci/prow/e2e-hypershift 01103a4 link true /test e2e-hypershift
ci/prow/security 01103a4 link false /test security
ci/prow/e2e-gcp-op-single-node 01103a4 link true /test e2e-gcp-op-single-node

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants