Skip to content

Added Flake Attempt to 3 for ConfigMap Changes #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sureshch2 wants to merge 1 commit into from
Closed

Added Flake Attempt to 3 for ConfigMap Changes #351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions osde2e/managed_cluster_validating_webhooks_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,8 @@ var _ = Describe("Managed Cluster Validating Webhooks", Ordered, func() {

It("should create a pod with the correct security context", func() {
pod := &v1.Pod{
ObjectMeta: metav1.ObjectMeta{
Name: "testpod",
Namespace: namespaceName,
ObjectMeta: metav1.ObjectMeta{
Name: "testpod",
},
Spec: v1.PodSpec{
Containers: []v1.Container{
Expand Down Expand Up @@ -151,8 +150,7 @@ var _ = Describe("Managed Cluster Validating Webhooks", Ordered, func() {
name := envconf.RandomName("testpod", 12)
pod = &v1.Pod{
ObjectMeta: metav1.ObjectMeta{
Name: name,
Namespace: testNsName,
Name: name,
},
Spec: v1.PodSpec{
Containers: []v1.Container{
Expand Down Expand Up @@ -325,7 +323,7 @@ var _ = Describe("Managed Cluster Validating Webhooks", Ordered, func() {
Expect(err).ShouldNot(HaveOccurred(), "Unable to create test namespace")
})

It("only blocks configmap/user-ca-bundle changes", func(ctx context.Context) {
It("only blocks configmap/user-ca-bundle changes", FlakeAttempts(3), func(ctx context.Context) {
cm := &v1.ConfigMap{ObjectMeta: metav1.ObjectMeta{Name: "user-ca-bundle", Namespace: "openshift-config"}}
err := dedicatedAdmink8s.Delete(ctx, cm)
Expect(errors.IsForbidden(err)).To(BeTrue(), "Expected to be forbidden from deleting user-ca-bundle ConfigMap")
Expand Down