Skip to content

Fix USHIFT-5528 #4813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

kasturinarra
Copy link

Which issue(s) this PR addresses:

This PR address to add a new option to scenario.sh to target any given VM.

For example: ./test/bin/scenario.sh run_on_vm <vm_ip> ./test/scenarios/periodics/[email protected]

Closes https://issues.redhat.com/browse/USHIFT-5528

@openshift-ci openshift-ci bot requested review from agullon and ggiguash April 17, 2025 19:11
Copy link
Contributor

openshift-ci bot commented Apr 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kasturinarra
Once this PR has been reviewed and has the lgtm label, please assign jerpeter1 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kasturinarra
Copy link
Author

@agullon @jogeo could you please help review the PR ? thanks !!

@agullon
Copy link
Contributor

agullon commented Apr 21, 2025

@agullon @jogeo could you please help review the PR ? thanks !!

I can see you are duplicating code. For example, to create variables.yaml file and execute RF tests. Can you reuse existing code, please?

Copy link
Contributor

openshift-ci bot commented Apr 21, 2025

@kasturinarra: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-tests-bootc-periodic-arm 9637f97 link true /test e2e-aws-tests-bootc-periodic-arm
ci/prow/e2e-aws-tests-periodic-arm 9637f97 link true /test e2e-aws-tests-periodic-arm
ci/prow/e2e-aws-tests-bootc-arm 9637f97 link true /test e2e-aws-tests-bootc-arm
ci/prow/e2e-aws-tests-bootc 9637f97 link true /test e2e-aws-tests-bootc
ci/prow/e2e-aws-tests-bootc-periodic 9637f97 link true /test e2e-aws-tests-bootc-periodic
ci/prow/verify 9637f97 link true /test verify
ci/prow/e2e-aws-tests-periodic 9637f97 link true /test e2e-aws-tests-periodic
ci/prow/e2e-aws-tests-arm 9637f97 link true /test e2e-aws-tests-arm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants