Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-44857: Separate resources with comma to fix malformed inspect #465

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

palonsoro
Copy link
Contributor

Fix for: https://issues.redhat.com/browse/OCPBUGS-44857

oc adm inspect --all-namespaces command was malformed, so its resources were never gathered.

oc adm inspect --all-namespaces command was malformed, so its resources
were never gathered.
@palonsoro palonsoro changed the title Fixed all namespaces inspect. [OCPBUGS-44857] Fixed all namespaces inspect Nov 21, 2024
@palonsoro
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@palonsoro: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@palonsoro palonsoro changed the title [OCPBUGS-44857] Fixed all namespaces inspect OCPBUGS-44857: Fixed all namespaces inspect Nov 21, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 21, 2024
@openshift-ci-robot
Copy link

@palonsoro: This pull request references Jira Issue OCPBUGS-44857, which is invalid:

  • expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.19.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fix for: https://issues.redhat.com/browse/OCPBUGS-44857

oc adm inspect --all-namespaces command was malformed, so its resources were never gathered.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@palonsoro
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@palonsoro: This pull request references Jira Issue OCPBUGS-44857, which is invalid:

  • expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.19.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@palonsoro
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 21, 2024
@openshift-ci-robot
Copy link

@palonsoro: This pull request references Jira Issue OCPBUGS-44857, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from zhouying7780 November 21, 2024 17:17
@flavianmissi
Copy link
Member

/lgtm

Since we let a couple of bugs slip in I'll put this on hold until someone from QE can test this.
/hold

@zhouying7780 you previously have helped me test changes in must-gather repository, are you able to do pre-merge testing on this PR?

/retest

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2024
@palonsoro
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@palonsoro: This pull request references Jira Issue OCPBUGS-44857, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@zhouying7780
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 25, 2024
@zhouying7780
Copy link

build the must-gather image and tested , can't reproduce the issue now :
error: there is no need to specify a resource type as a separate argument when passing arguments in resource/name form (e.g. 'oc get resource/<resource_name>' instead of 'oc get resource resource/<resource_name>'

@flavianmissi
Copy link
Member

Assigning Arda for approval

/assign @ardaguclu

@ardaguclu
Copy link
Member

Thank you
/retitle OCPBUGS-44857: Separate resources with comma to fix malformed inspect
/approve

@openshift-ci openshift-ci bot changed the title OCPBUGS-44857: Fixed all namespaces inspect OCPBUGS-44857: Separate resources with comma to fix malformed inspect Nov 25, 2024
@ardaguclu
Copy link
Member

/retest

Copy link
Contributor

openshift-ci bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, flavianmissi, palonsoro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ardaguclu
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 25, 2024
@palonsoro
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@palonsoro: This pull request references Jira Issue OCPBUGS-44857, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Nov 25, 2024

@palonsoro: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit c211c0b into openshift:master Nov 25, 2024
4 checks passed
@openshift-ci-robot
Copy link

@palonsoro: Jira Issue OCPBUGS-44857: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-44857 has been moved to the MODIFIED state.

In response to this:

Fix for: https://issues.redhat.com/browse/OCPBUGS-44857

oc adm inspect --all-namespaces command was malformed, so its resources were never gathered.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-must-gather
This PR has been included in build ose-must-gather-container-v4.19.0-202411260335.p0.gc211c0b.assembly.stream.el9.
All builds following this will include this PR.

@palonsoro
Copy link
Contributor Author

/cherrypick release-4.18

@openshift-cherrypick-robot

@palonsoro: new pull request created: #470

In response to this:

/cherrypick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants