Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] [release-4.15] Fix collecting IPsec data for upgrade #483

Open
wants to merge 1 commit into
base: release-4.15
Choose a base branch
from

Conversation

pperiyasamy
Copy link
Member

@pperiyasamy pperiyasamy commented Mar 4, 2025

After IPsec is upgraded from 4.14 into later versions, API option for IPsec in networks.operator.openshift.io cluster object continues to have {} in the ipsecConfig and may not be migrated to newer version containing IPsec mode option. This is supported in OCP for backward compatibility, so mg needs fixing to collect ipsec data when API configured with old option.

Signed-off-by: Periyasamy Palanisamy [email protected]
(cherry picked from commit e4e2e33)

No Conflicts.

After IPsec is upgraded from 4.14 into later versions, API option for IPsec in
networks.operator.openshift.io cluster object continues to have {} in the ipsecConfig
and may not be migrated to newer version containing IPsec mode option. This is supported
in OCP for backward compatibility, so mg needs fixing to collect ipsec data when API
configured with old option.

Signed-off-by: Periyasamy Palanisamy <[email protected]>
(cherry picked from commit e4e2e33)
@openshift-ci openshift-ci bot requested review from davemulford and sferich888 March 4, 2025 08:11
Copy link
Contributor

openshift-ci bot commented Mar 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pperiyasamy
Once this PR has been reviewed and has the lgtm label, please assign sferich888 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pperiyasamy
Copy link
Member Author

/assign @huiran0826

Copy link
Contributor

openshift-ci bot commented Mar 4, 2025

@pperiyasamy: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants