Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORENET-5882: network: gather routeadvertisements.k8s.ovn.org #485

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CORENET-5882: network: gather routeadvertisements.k8s.ovn.org #485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions collection-scripts/gather_network_logs_basics
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,11 @@ if [[ "${CNCC_DEPLOYMENT}" == "cloud-network-config-controller" ]]; then
oc adm inspect ${log_collection_args} --dest-dir must-gather cloudprivateipconfigs.cloud.network.openshift.io
fi

ROUTE_ADVERTISEMENTS=$(oc get network.operator.openshift.io cluster -o=jsonpath='{.spec.defaultNetwork.ovnKubernetesConfig.routeAdvertisements}')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this go into the check for only if network plugin is ovnk? i think we still support 3rd party plugins? but there we wouldn't have the .ovnkConfig set so value will be blank is it?

if [[ "${ROUTE_ADVERTISEMENTS}" == "Enabled" ]]; then
oc adm inspect ${log_collection_args} --dest-dir must-gather routeadvertisements.k8s.ovn.org
fi

echo "INFO: Waiting for network log collection to complete ..."
if [[ "${NETWORK_TYPE}" == "ovnkubernetes" ]]; then
echo "INFO: Waiting for ovnk database copies to complete ..."
Expand Down