Skip to content

Conversation

@MaxBab
Copy link

@MaxBab MaxBab commented Nov 6, 2025

If ZTunnel resource exists, collect its resources.

If ZTunnel resource exists, collect its resources.
@MaxBab MaxBab force-pushed the collect_istio_ztunnel_resources branch from e4b83ca to 610a7e1 Compare November 9, 2025 11:35
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 9, 2025

@MaxBab: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

@sridhargaddam sridhargaddam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MaxBab

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MaxBab, sridhargaddam
Once this PR has been reviewed and has the lgtm label, please assign sferich888 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MaxBab
Copy link
Author

MaxBab commented Nov 16, 2025

Hello @ingvagabund @sferich888

Could you take a look at the patch, please?

@ingvagabund
Copy link
Member

This looks like a single object to collect + related objects. What's the largest amount of data collected in the worst case? Can the collected resources include user defined namespaces as well?

@MaxBab
Copy link
Author

MaxBab commented Nov 30, 2025

Hello @ingvagabund

Sorry for the late response.
I've missed your message.

So, this PR adds a collect step of a resource that being deployed in specific mode of istio.
Regarding the user defined namespaces - we already filtering and fetching the namespaces created by the user, which uses istio for the workload.

@MaxBab
Copy link
Author

MaxBab commented Dec 23, 2025

Hello @ingvagabund

Could you take a look at the review, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants