-
Notifications
You must be signed in to change notification settings - Fork 216
Collect Istio ZTunnel resources #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
If ZTunnel resource exists, collect its resources.
e4b83ca to
610a7e1
Compare
|
@MaxBab: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
sridhargaddam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MaxBab
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: MaxBab, sridhargaddam The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hello @ingvagabund @sferich888 Could you take a look at the patch, please? |
|
This looks like a single object to collect + related objects. What's the largest amount of data collected in the worst case? Can the collected resources include user defined namespaces as well? |
|
Hello @ingvagabund Sorry for the late response. So, this PR adds a collect step of a resource that being deployed in specific mode of istio. |
|
Hello @ingvagabund Could you take a look at the review, please? |
If ZTunnel resource exists, collect its resources.