Skip to content

[WIP] CNV-52160: UDN with topology selector #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

upalatucci
Copy link

@upalatucci upalatucci commented Apr 8, 2025

Description

Let users select primary or secondary udn.

With primary Layer2 and Layer3 are available.
With secondary, only localnet is available

  • Move error from the form to the modal footer so it will be visible also on scrolled body.

  • Change CIRD to CIDR

WIP as localnet is not ready in the backend : ovn-kubernetes/ovn-kubernetes#5010

Demo

Screen.Recording.2025-04-08.at.11.48.10.mov

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 8, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 8, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 8, 2025

@upalatucci: This pull request references CNV-52160 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.19." or "openshift-4.19.", but it targets "CNV v4.19.0" instead.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from metalice and pcbailey April 8, 2025 09:44
Copy link

openshift-ci bot commented Apr 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 8, 2025

@upalatucci: This pull request references CNV-52160 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.19." or "openshift-4.19.", but it targets "CNV v4.19.0" instead.

In response to this:

Description

Let users select primary or secondary udn.

With primary Layer2 and Layer3 are available.
With secondary, only localnet is available

Demo

Screen.Recording.2025-04-08.at.11.48.10.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 8, 2025

@upalatucci: This pull request references CNV-52160 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.19." or "openshift-4.19.", but it targets "CNV v4.19.0" instead.

In response to this:

Description

Let users select primary or secondary udn.

With primary Layer2 and Layer3 are available.
With secondary, only localnet is available

WIP as localnet is not ready in the backend

Demo

Screen.Recording.2025-04-08.at.11.48.10.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 15, 2025

@upalatucci: This pull request references CNV-52160 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.19." or "openshift-4.19.", but it targets "CNV v4.19.0" instead.

In response to this:

Description

Let users select primary or secondary udn.

With primary Layer2 and Layer3 are available.
With secondary, only localnet is available

WIP as localnet is not ready in the backend : ovn-kubernetes/ovn-kubernetes#5010

Demo

Screen.Recording.2025-04-08.at.11.48.10.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@upalatucci upalatucci changed the title [WIP] CNV-52160: UDN with topology selector CNV-52160: UDN with topology selector Apr 17, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 17, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 17, 2025

@upalatucci: This pull request references CNV-52160 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.19." or "openshift-4.19.", but it targets "CNV v4.19.0" instead.

In response to this:

Description

Let users select primary or secondary udn.

With primary Layer2 and Layer3 are available.
With secondary, only localnet is available

  • Move error from the form to the modal footer so it will be visible also on scrolled body.

  • Change CIRD to CIDR

WIP as localnet is not ready in the backend : ovn-kubernetes/ovn-kubernetes#5010

Demo

Screen.Recording.2025-04-08.at.11.48.10.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@upalatucci upalatucci changed the title CNV-52160: UDN with topology selector [WIP] CNV-52160: UDN with topology selector Apr 17, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 17, 2025
Copy link

openshift-ci bot commented Apr 17, 2025

@upalatucci: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/lint e0513e2 link true /test lint
ci/prow/e2e e0513e2 link true /test e2e
ci/prow/images e0513e2 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants