KFLUXMIG-940: oc version change in OCP Jenkins #103911
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@k37y: This pull request references KFLUXMIG-940 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
size/L
openshift-ci
bot
added
size/M
k37y
force-pushed
the
kfluxmig-940
branch
5 times, most recently
from
5ab537b to
e4afc33
Compare
|
/label merge-review-needed |
openshift-ci
bot
added
the
merge-review-needed
|
/verified by @prdhamdh |
|
/cherry-pick release-4.20 release-4.19 release-4.18 release-4.17 release-4.16 release-4.15 release-4.14 release-4.13 release-4.12 |
|
@k37y: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick enterprise-4.20 |
|
@k37y: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ShaunaDiaz
added
merge-review-in-progress
|
@k37y: This pull request references KFLUXMIG-940 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
ShaunaDiaz
left a comment
ShaunaDiaz
left a comment
There was a problem hiding this comment.
Looks good! I know, a lot of comments. We are preparing for a docs tooling conversion and don't want to introduce new errors to the repo.
|
|
||
| If your Jenkins pipelines require a *specific* `oc` client version for compatibility or reproducibility, you must explicitly configure the desired client version in the Jenkins pipeline DSL. | ||
|
|
||
| == OpenShift Jenkins release vs Bundled `oc` client version |
There was a problem hiding this comment.
this should be a separate Reference module
openshift-ci
bot
added
size/L
| @@ -0,0 +1,98 @@ | |||
| // Module included in the following assemblies: | |||
There was a problem hiding this comment.
🤖 [error] AsciiDocDITA.TaskContents: The '.Procedure' block title is missing.
|
|
||
| :_mod-docs-content-type: PROCEDURE | ||
|
|
||
| [id="about-the-openshift-cli-in-jenkins-images_{context}"] |
There was a problem hiding this comment.
🤖 [error] OpenShiftAsciiDoc.IdHasContextVariable: ID is missing the '_{context}' variable at the end of the ID.
| [role="_abstract"] | ||
| You can ensure that your Jenkins pipeline uses your specified `oc` client version with the Jenkins container image by configuring the version you require. | ||
| * Define the `oc` tool version explicitly in the pipeline configuration to use a specific OpenShift client version in a Jenkins pipeline as shown in the following example: | ||
| .Example pipeline configuration |
There was a problem hiding this comment.
🤖 [error] AsciiDocDITA.TaskTitle: Unsupported titles cannot be mapped to DITA tasks.
There was a problem hiding this comment.
this error will go away once you have this procedure in a standalone module
|
|
||
| If your Jenkins pipelines require a *specific* `oc` client version for compatibility or reproducibility, you must explicitly configure the desired client version in the Jenkins pipeline DSL. | ||
|
|
||
| // Module included in the following assemblies: |
There was a problem hiding this comment.
this should start a new module
| | 4.16, 4.17, 4.18, 4.19, 4.20 | ||
| |=== | ||
|
|
||
| // Module included in the following assemblies: |
There was a problem hiding this comment.
this should start a new module
| :_mod-docs-content-type: PROCEDURE | ||
| [id="specify-oc-ocp-jenkins-image_context"] | ||
| = Specify a fixed `oc` client version for OpenShift Jenkins images | ||
| [role="_abstract"] |
There was a problem hiding this comment.
| [role="_abstract"] | |
| [role="_abstract"] |
need a line space here
| [role="_abstract"] | ||
| You can ensure that your Jenkins pipeline uses your specified `oc` client version with the Jenkins container image by configuring the version you require. | ||
| * Define the `oc` tool version explicitly in the pipeline configuration to use a specific OpenShift client version in a Jenkins pipeline as shown in the following example: | ||
| .Example pipeline configuration |
There was a problem hiding this comment.
this error will go away once you have this procedure in a standalone module
| // * cicd/jenkins/important-changes-to-openshift-jenkins-images.adoc | ||
|
|
||
| :_mod-docs-content-type: REFERENCE | ||
| [id="ocp-jenkins-release-oc-client-table_{context}"] |
There was a problem hiding this comment.
you can use the id as the filename to keep things consistent; so make this a module that is called:
ocp-jenkins-release-oc-client-table.adoc
(same with the procedure; you can reuse the ID as the filename)
| include::modules/customizing-the-jenkins-image-stream-tag.adoc[leveloffset=+1] | ||
|
|
||
| include::modules/usage-of-latest-openshift-client.adoc[leveloffset=+1] | ||
|
|
There was a problem hiding this comment.
| include::modules/specify-oc-ocp-jenkins-image[leveloffset=+1] | |
| include::modules/ocp-jenkins-release-oc-client-table.adoc[leveloffset=+1] |
after you make the module files, you add the include statements to the assembly
k37y
force-pushed
the
kfluxmig-940
branch
3 times, most recently
from
cbc9ace to
bbc648c
Compare
| @@ -0,0 +1,31 @@ | |||
| // Module included in the following assemblies: | |||
There was a problem hiding this comment.
🤖 [error] AsciiDocDITA.TaskContents: The '.Procedure' block title is missing.
| // * cicd/jenkins/important-changes-to-openshift-jenkins-images.adoc | ||
|
|
||
| :_mod-docs-content-type: PROCEDURE | ||
| [id="specifying-oc-ocp-jenkins-image_context"] |
There was a problem hiding this comment.
🤖 [error] OpenShiftAsciiDoc.IdHasContextVariable: ID is missing the '_{context}' variable at the end of the ID.
| :_mod-docs-content-type: PROCEDURE | ||
| [id="specifying-oc-ocp-jenkins-image_context"] | ||
| = Specifying a fixed `oc` client version for OpenShift Jenkins images | ||
| [role="_abstract"] |
There was a problem hiding this comment.
🤖 [error] AsciiDocDITA.AuthorLine: Author lines are not supported for topics.
| * Define the `oc` tool version explicitly in the pipeline configuration to use a specific OpenShift client version in a Jenkins pipeline as shown in the following example: | ||
| .Example pipeline configuration |
There was a problem hiding this comment.
🤖 [error] AsciiDocDITA.TaskTitle: Unsupported titles cannot be mapped to DITA tasks.
|
/test validate-portal |
| * Define the `oc` tool version explicitly in the pipeline configuration to use a specific OpenShift client version in a Jenkins pipeline as shown in the following example: | ||
| .Example pipeline configuration | ||
| [source,groovy,subs="attributes+"] |
There was a problem hiding this comment.
| [source,groovy,subs="attributes+"] | |
| [source,terminal,subs="attributes+"] |
try this and let's see if it builds
i see a rather cryptic error: "�[31m�[1mattributes construct error, line 1597, column 17 (master.xml, line 1597)�[0m"
Add documentation explaining that Jenkins images from OpenShift 4.12 onward bundle a newer oc client by default and show how to pin a specific oc version using the tools stanza in Jenkins pipelines. Signed-off-by: Vinu Kochukuttan <[email protected]>
|
/test validate-portal |
3 similar comments
|
/test validate-portal |
|
/test validate-portal |
|
/test validate-portal |
|
@k37y: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
7 participants
Add documentation explaining that Jenkins images from OpenShift 4.12 onward bundle a newer oc client by default and show how to pin a specific oc version using the tools stanza in Jenkins pipelines.
Version(s):
4.12
4.13
4.14
4.15
4.16
4.17
4.18
4.19
4.20
Issue:
https://issues.redhat.com/browse/KFLUXMIG-940
Link to docs preview:
https://103911--ocpdocs-pr.netlify.app/openshift-dedicated/latest/cicd/jenkins/important-changes-to-openshift-jenkins-images.html
https://103911--ocpdocs-pr.netlify.app/openshift-enterprise/latest/cicd/jenkins/important-changes-to-openshift-jenkins-images.html
https://103911--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/cicd/jenkins/important-changes-to-openshift-jenkins-images.html
https://103911--ocpdocs-pr.netlify.app/openshift-rosa/latest/cicd/jenkins/important-changes-to-openshift-jenkins-images.html
QE review:
Additional information: