Skip to content

[WIP] DOCPLAN-31: Remove unnecessary module, move to admonition #104285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abrennan89 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[WIP] DOCPLAN-31: Remove unnecessary module, move to admonition #104285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30c7e26
DOCPLAN-31: Remove unnecessary module, move to admonition
abrennan89 Dec 23, 2025
1359273
update structure
abrennan89 Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions modules/virt-configuring-certificate-rotation.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,41 @@ spec:
renewBefore: 12h0m0s
----
+
Deleting one or more `certConfig` values in the `HyperConverged` CR causes the `certConfig` values to revert to the default values. If the default values conflict with one of the following conditions, you receive an error message instead:
+
** The value of `ca.renewBefore` must be less than or equal to the value of `ca.duration`.
** The value of `server.duration` must be less than or equal to the value of `ca.duration`.
** The value of `server.renewBefore` must be less than or equal to the value of `server.duration`.
+
For example, if you remove the `server.duration` value, the default value of `24h0m0s` is greater than the value of `ca.duration`, which conflicts with the specified conditions:
+
[source,yaml,subs="attributes+"]
----
apiVersion: hco.kubevirt.io/v1beta1
kind: HyperConverged
metadata:
name: kubevirt-hyperconverged
namespace: {CNVNamespace}
spec:
# ...
certConfig:
ca:
duration: 4h0m0s
renewBefore: 1h0m0s
server:
duration: 4h0m0s
renewBefore: 4h0m0s
# ...
----
+
This results in the following error message:
+
[source,terminal]
----
error: hyperconvergeds.hco.kubevirt.io "kubevirt-hyperconverged" could not be patched: admission webhook "validate-hco.kubevirt.io" denied the request: spec.certConfig: ca.duration is smaller than server.duration
----
+
The error message only mentions the first conflict. Review all `certConfig` values before you proceed.

. Apply updates to the `HyperConverged` CR by running the following command:
+
Expand Down
46 changes: 0 additions & 46 deletions modules/virt-troubleshooting-cert-rotation-parameters.adoc
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion virt/post_installation_configuration/virt-configuring-certificate-rotation.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,3 @@ Configure certificate rotation parameters to replace existing certificates.
toc::[]

include::modules/virt-configuring-certificate-rotation.adoc[leveloffset=+1]
include::modules/virt-troubleshooting-cert-rotation-parameters.adoc[leveloffset=+1]