Skip to content

BZ-1778362: Adding how to update HTPasswd IDP with new user list #20508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2020

Conversation

@bergerhoffer bergerhoffer added this to the Next Release milestone Mar 17, 2020
@bergerhoffer
Copy link
Contributor Author

@openshift/team-documentation For peer review please.

@openshift-docs-preview-bot

The preview will be available shortly at:

@bergerhoffer
Copy link
Contributor Author

@stlaz Can you check out this new procedure to update after adding or removing users from an HTPasswd file? I pulled the steps together from various places, and they work for me, but let me know if there is a different procedure that is preferable.

Preview: https://bz-1778362--ocpdocs.netlify.com/openshift-enterprise/latest/authentication/identity_providers/configuring-htpasswd-identity-provider.html#identity-provider-htpasswd-update-users_configuring-htpasswd-identity-provider

@adellape adellape self-requested a review March 17, 2020 12:59
Copy link
Contributor

@adellape adellape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@adellape adellape added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 17, 2020
user.user.openshift.io "<username>" deleted
----
+
// TODO: A user doesn't get [immediately, or at all?] kicked out of a session until you delete the user?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to remove all of their oauthaccesstokens

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stlaz What would be the command(s) to do that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per DMs, if you've already removed the user object, the user should be able to use their accesstoken anyway

user.user.openshift.io "<username>" deleted
----
+
Be sure to remove the user, otherwise the user can continue using their token as long as it has not expired.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stlaz Is this wording okay per our discussion?

@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented Apr 8, 2020

@xingxingxia
Copy link
Contributor

@rhpmali is the owner of IDP configuration now, he will review this PR. I'll double review.

@rhpmali
Copy link

rhpmali commented Apr 9, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2020
@xingxingxia
Copy link
Contributor

LGTM

@bergerhoffer
Copy link
Contributor Author

Thanks @rhpmali and @xingxingxia! Merging.

@bergerhoffer bergerhoffer merged commit 972136c into openshift:master Apr 13, 2020
@bergerhoffer
Copy link
Contributor Author

/cherrypick enterprise-4.4

@bergerhoffer
Copy link
Contributor Author

/cherrypick enterprise-4.3

@bergerhoffer
Copy link
Contributor Author

/cherrypick enterprise-4.2

@openshift-cherrypick-robot

@bergerhoffer: new pull request created: #21095

In response to this:

/cherrypick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@bergerhoffer: new pull request created: #21096

In response to this:

/cherrypick enterprise-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@bergerhoffer: new pull request created: #21097

In response to this:

/cherrypick enterprise-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.2 branch/enterprise-4.3 branch/enterprise-4.4 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants