Add overriding proxy for OLM #20591
Add overriding proxy for OLM #20591
Conversation
|
The preview will be available shortly at: |
adellape
force-pushed
the
olm_proxy_override
branch
3 times, most recently
from
63a8784 to
c734ef0
Compare
adellape
added
peer-review-needed
adellape
force-pushed
the
olm_proxy_override
branch
from
c734ef0 to
13bf53c
Compare
|
@ecordell PTAL |
adellape
added
the
peer-review-needed
|
|
||
| - Access to an {product-title} cluster using an account with | ||
| ifdef::openshift-enterprise,openshift-webscale,openshift-origin[] | ||
| `cluster-admin` permissions. |
There was a problem hiding this comment.
Is it permission or permissions?
I've always written permissions, but I do wonder.
There was a problem hiding this comment.
Can't find guidance on this, though I see way more "permissions" in our source versus "permission" (particularly if you omit modules/apis.adoc 🙂).
| @@ -15,4 +15,9 @@ include::modules/olm-installing-from-operatorhub-using-cli.adoc[leveloffset=+2] | |||
| .Additional resources | |||
|
|
|||
| * xref:../operators/understanding_olm/olm-understanding-operatorgroups.adoc#olm-operatorgroups-about_olm-understanding-operatorgroups[About OperatorGroups] | |||
|
|
|||
| include::modules/olm-overriding-proxy-settings.adoc[leveloffset=+1] | |||
There was a problem hiding this comment.
Does this need a space after the include?
There was a problem hiding this comment.
The only spacing like this I've found that's required is a blank line before the include, otherwise you get a verbatim leveloffset in the text. Works fine with no space after it, and I like to see the "Additional resources" list clearly adjacent to the module it's related to.
jboxman
added
peer-review-done
adellape
force-pushed
the
olm_proxy_override
branch
from
13bf53c to
bda5db6
Compare
| [NOTE] | ||
| ==== | ||
| These environment variables can also be unset using an empty value to remove any | ||
| previously set cluster-wide or custom proxy settings. |
There was a problem hiding this comment.
This note will go into master and 4.4, but will be swapped in 4.2 and 4.3 for info on the Known Issue https://bugzilla.redhat.com/show_bug.cgi?id=1751903, with a link to the relevant release note.
|
LGTM considering https://bugzilla.redhat.com/show_bug.cgi?id=1751903#c24 comment, thanks. |
|
/cherry-pick enterprise-4.4 |
|
@adellape: new pull request created: #21079 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Manually cherry-picked to enterprise-4.2 w/ tweaks via #21081. |
|
Manually cherry-picked to enterprise-4.3 w/ tweaks via #20591. |
JIRA: https://issues.redhat.com/browse/OSDOCS-980
xref: https://bugzilla.redhat.com/show_bug.cgi?id=1751903
Preview (internal): http://file.rdu.redhat.com/~adellape/031920/olm_proxy_override/operators/olm-adding-operators-to-cluster.html#olm-overriding-proxy-settings_olm-adding-operators-to-a-cluster