-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Fix style for options that are not compulsory #20616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The preview will be available shortly at: |
We should be consistent where we can.
No. That would just add more overhead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mburke5678 @apinnick @maximsvistunov FYI, I replaced instances of _Optionally, _ with _Optional: _ per IBM style guide for what appear to be procedures. Let me know if that isn't correct for your modules. Thanks! |
/cherry-pick enterprise-4.5 |
/cherry-pick enterprise-4.4 |
@jboxman: new pull request created: #22180 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jboxman: new pull request created: #22181 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick enterprise-4.3 |
@jboxman: new pull request created: #22182 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick enterprise-4.2 |
@jboxman: #20616 failed to apply on top of branch "enterprise-4.2":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
So IBM says:
Do we care about a period versus a colon for this? Do we care about optional versus optionally?
And do we want to offset this semantically, with italics or bold? (We do no, currently.)